FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

Remove promotion entities and endpoints #62

Manually merged
Johann150 merged 5 commits from feature/remove-promo-notes into main 2022-08-18 12:27:35 +00:00
Conversation 4 Commits 5 Files Changed 32 +26 -286
pixeldesu commented 2022-08-11 21:17:50 +00:00
Owner
Copy Link

Saw some posts on fedi about these entities and endpoints that are actually unused.

The client code is partially present, but commented out.

Saw some posts on fedi about these entities and endpoints that are actually unused. The client code is partially present, but commented out.
pixeldesu added 2 commits 2022-08-11 21:17:50 +00:00
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline failed Details
ci/woodpecker/push/test Pipeline failed Details
c7bf29fd49 Remove promo entities and endpoints
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline failed Details
ci/woodpecker/push/test Pipeline failed Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
7f806ca06b Remove client promotion code
Johann150 requested changes 2022-08-12 06:04:14 +00:00
Johann150 left a comment
Owner
Copy Link

There is some related code still in packages/backend/src/server/api/endpoints.ts.

There is some related code still in `packages/backend/src/server/api/endpoints.ts`.
Johann150 added 2 commits 2022-08-12 17:42:25 +00:00
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline failed Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/push/test Pipeline failed Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
745df85809
remove promo note locales
pixeldesu force-pushed feature/remove-promo-notes from 0789ba5508 to 745df85809 2022-08-12 20:32:33 +00:00 Compare
pixeldesu commented 2022-08-12 20:33:39 +00:00
Author
Owner
Copy Link

Didn't see that you also pushed commits until I got to a merge. I force-push-removed my one commit and the merge that is shown in the UI, your commits are the last ones now.

Didn't see that you also pushed commits until I got to a merge. I force-push-removed my one commit and the merge that is shown in the UI, your commits are the last ones now.
Johann150 commented 2022-08-12 21:18:24 +00:00
Owner
Copy Link

I removed the stuff I found. If you don't see anything else I think this can be merged.

I removed the stuff I found. If you don't see anything else I think this can be merged.
pixeldesu commented 2022-08-12 22:21:02 +00:00
Author
Owner
Copy Link

didn't find anything else, so I think this is ready

didn't find anything else, so I think this is ready
toast commented 2022-08-13 00:57:54 +00:00
Owner
Copy Link

I'm not noticing anything - I'll give it tomorrow and merge it at end of day (and update toast cafe straightaway after that) unless something else is found.

I'm not noticing anything - I'll give it tomorrow and merge it at end of day (and update toast cafe straightaway after that) unless something else is found.
Johann150 added 1 commit 2022-08-14 11:14:54 +00:00
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline failed Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/push/test Pipeline failed Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
39b85f4a08
client: remove _prId_ 
That property was set on promo notes in the backend. Since it is no longer
being used it should also be removed from the client.
Johann150 approved these changes 2022-08-15 15:28:04 +00:00
Johann150 left a comment
Owner
Copy Link

I think we got everything now. Looks good to merge for me.

I think we got everything now. Looks good to merge for me.
Johann150 referenced this issue from a commit 2022-08-18 12:27:32 +00:00
merge: remove promo notes
Johann150 manually merged commit b137a39160 into main 2022-08-18 12:27:35 +00:00
norm referenced this issue from a commit 2022-08-18 20:58:14 +00:00
Update CHANGELOG for PR #62
Johann150 deleted branch feature/remove-promo-notes 2022-08-19 07:18:42 +00:00
toast referenced this issue from a commit 2022-08-26 13:21:48 +00:00
Update CHANGELOG for PR #62
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#62
No description provided.
Delete Branch "feature/remove-promo-notes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?