refactor: button.vue to composition api #79

Closed
norm wants to merge 3 commits from refactor/button into main
Owner
No description provided.
norm force-pushed refactor/button from b32d45a385 to d10ab86474 2022-08-20 04:02:05 +00:00 Compare
Johann150 reviewed 2022-08-20 11:31:29 +00:00
@ -99,0 +28,4 @@
<script lang="ts" setup>
import { onMounted, nextTick } from 'vue';
const props = defineProps<{
Owner

The defaults still need to be added with withDefaults(defineProps..., { /* defaults */ }).

The defaults still need to be added with `withDefaults(defineProps..., { /* defaults */ })`.
norm marked this conversation as resolved
Owner

I'm not sure about the default for type. According to w3schools, there is no standardized default for button types. Testing it in Firefox it defaults to a submit button. I guess in most use cases here it does not even matter really because the buttons are not in <form>s but taking a quick look at how MkButton is used, type=button seems a better default.

I'm not sure about the default for `type`. According to w3schools, there is no standardized default for button types. Testing it in Firefox it defaults to a submit button. I guess in most use cases here it does not even matter really because the buttons are not in `<form>`s but taking a quick look at how `MkButton` is used, `type=button` seems a better default.
norm force-pushed refactor/button from fad2b49504 to 3f3782ac44 2022-08-20 15:46:08 +00:00 Compare
Author
Owner

taking a quick look at how MkButton is used, type=button seems a better default.

Yeah that makes sense.

> taking a quick look at how MkButton is used, type=button seems a better default. Yeah that makes sense.
norm force-pushed refactor/button from 3f3782ac44 to af3b39df5f 2022-08-20 15:47:08 +00:00 Compare
norm added 1 commit 2022-08-20 17:38:06 +00:00
button.vue: use null as default for props.to
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
ci/woodpecker/push/build Pipeline was successful
ci/woodpecker/push/lint-client Pipeline failed
ci/woodpecker/pr/lint-backend Pipeline was successful
ci/woodpecker/pr/build Pipeline was successful
ci/woodpecker/pr/lint-client Pipeline failed
ci/woodpecker/push/test Pipeline failed
ci/woodpecker/pr/test Pipeline failed
fd565f842c
Owner

manually merged in commit 7621e5461f and gitea doesnt want me to mark the PR as manually merged for some reason

manually merged in commit 7621e5461f84464fb2b5e99842e7457e651b379a and gitea doesnt want me to mark the PR as manually merged for some reason
Johann150 closed this pull request 2022-08-20 22:27:08 +00:00
Johann150 deleted branch refactor/button 2022-08-20 22:27:17 +00:00
toast referenced this pull request from a commit 2022-08-26 13:21:48 +00:00
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
ci/woodpecker/push/build Pipeline was successful
ci/woodpecker/push/lint-client Pipeline failed
ci/woodpecker/pr/lint-backend Pipeline was successful
ci/woodpecker/pr/build Pipeline was successful
ci/woodpecker/pr/lint-client Pipeline failed
ci/woodpecker/push/test Pipeline failed
ci/woodpecker/pr/test Pipeline failed

Pull request closed

Sign in to join this conversation.
No reviewers
No labels
feature
fix
upkeep
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#79
No description provided.