FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

refactor: button.vue to composition api #79

Closed
norm wants to merge 3 commits from refactor/button into main
pull from: refactor/button
merge into: FoundKeyGang:main
Conversation 3 Commits 3 Files Changed 1 +100 -119
norm commented 2022-08-20 03:55:46 +00:00
Owner
Copy Link
No description provided.
norm force-pushed refactor/button from b32d45a385 to d10ab86474 2022-08-20 04:02:05 +00:00 Compare
Johann150 reviewed 2022-08-20 11:31:29 +00:00
packages/client/src/components/ui/button.vue Outdated
@ -99,0 +28,4 @@
<script lang="ts" setup>
import { onMounted, nextTick } from 'vue';
const props = defineProps<{
Johann150 commented 2022-08-20 10:26:14 +00:00
Owner
Copy Link

The defaults still need to be added with withDefaults(defineProps..., { /* defaults */ }).

The defaults still need to be added with `withDefaults(defineProps..., { /* defaults */ })`.
norm marked this conversation as resolved
Johann150 commented 2022-08-20 15:43:38 +00:00
Owner
Copy Link

I'm not sure about the default for type. According to w3schools, there is no standardized default for button types. Testing it in Firefox it defaults to a submit button. I guess in most use cases here it does not even matter really because the buttons are not in <form>s but taking a quick look at how MkButton is used, type=button seems a better default.

I'm not sure about the default for `type`. According to w3schools, there is no standardized default for button types. Testing it in Firefox it defaults to a submit button. I guess in most use cases here it does not even matter really because the buttons are not in `<form>`s but taking a quick look at how `MkButton` is used, `type=button` seems a better default.
norm force-pushed refactor/button from fad2b49504 to 3f3782ac44 2022-08-20 15:46:08 +00:00 Compare
norm commented 2022-08-20 15:46:36 +00:00
Author
Owner
Copy Link

taking a quick look at how MkButton is used, type=button seems a better default.

Yeah that makes sense.

> taking a quick look at how MkButton is used, type=button seems a better default. Yeah that makes sense.
norm force-pushed refactor/button from 3f3782ac44 to af3b39df5f 2022-08-20 15:47:08 +00:00 Compare
norm added 1 commit 2022-08-20 17:38:06 +00:00
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline failed Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/push/test Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
fd565f842c
button.vue: use null as default for props.to
Johann150 commented 2022-08-20 22:27:08 +00:00
Owner
Copy Link

manually merged in commit 7621e5461f and gitea doesnt want me to mark the PR as manually merged for some reason

manually merged in commit 7621e5461f84464fb2b5e99842e7457e651b379a and gitea doesnt want me to mark the PR as manually merged for some reason
👍 1
Johann150 closed this pull request 2022-08-20 22:27:08 +00:00
Johann150 deleted branch refactor/button 2022-08-20 22:27:17 +00:00
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline failed
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/push/test Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#79
No description provided.
Delete Branch "refactor/button"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?