fix: alt text for non-image files #106

Merged

norm merged 2 commits from media-caption into main 2022-09-03 23:37:28 +00:00

Conversation 0 Commits 2 Files changed 3 +15 -8

Johann150 commented 2022-09-03 22:26:56 +00:00

Owner

Copy link

Fixes https://github.com/misskey-dev/misskey/issues/8701:

When I add a description for a video, the <img> tag points to the video file and nothing is shown.

This will just show the image/video/audio or a link to the file if it is none of those media types. This might lead people to try to write complete transcriptions of audio files etc. which would not be the intended use but I think it should be fine with the current limit on alt text length.

Fixes <https://github.com/misskey-dev/misskey/issues/8701>: > When I add a description for a video, the `<img>` tag points to the video file and nothing is shown. This will just show the image/video/audio or a link to the file if it is none of those media types. This might lead people to try to write complete transcriptions of audio files etc. which would not be the intended use but I think it should be fine with the current limit on alt text length.

Johann150 added 2 commits 2022-09-03 22:26:57 +00:00

rename prop: image -> file 525c8391a6

Client: alt text dialog properly handles non-images ... 00c8eff611

Changelog: Changed

toast approved these changes 2022-09-03 23:31:33 +00:00

norm merged commit 500c0be179 into main 2022-09-03 23:37:28 +00:00

norm deleted branch media-caption 2022-09-03 23:37:28 +00:00

norm referenced this pull request from a commit 2022-09-03 23:37:29 +00:00

client: fix alt text for non-image files

Michcio referenced this pull request 2022-09-06 12:11:40 +00:00

client: Fix typo in media caption code #112

Sign in to join this conversation.

Reviewers

No reviewers

toast

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#106

No description provided.