Use native shell commands for clean/clean-all #110

Manually merged

Johann150 merged 2 commits from refactor/remove-clean-scripts into main 2022-09-05 22:09:16 +00:00

Conversation 2 Commits 2 Files changed 8 +16 -34

norm commented 2022-09-05 08:44:33 +00:00

Owner

Copy link

No description provided.

norm added 1 commit 2022-09-05 08:44:34 +00:00

Use native shell commands for clean/clean-all 5fb294e7d7

Johann150 commented 2022-09-05 10:08:20 +00:00

Owner

Copy link

I think the point of not using the native shell was to be cross-platform (specifically Windows). Do we want to abandon that idea? If so it would be a good idea to at least note that in the readme/contributing guide/...

I think the point of not using the native shell was to be cross-platform (specifically Windows). Do we want to abandon that idea? If so it would be a good idea to at least note that in the readme/contributing guide/...

norm commented 2022-09-05 15:50:31 +00:00

Author

Owner

Copy link

The npm scripts that already exist do seem to already assume a Unix-like shell using chaining operators like && and ||. To be fair, those did get added to PowerShell 7.0, but judging by git blame on the main package.json, those do predate PS 7.0 by several years. Unless NPM already does some special handling for those under Windows...

I'll at least make a note in the contributing guide though.

The npm scripts that already exist do seem to already assume a Unix-like shell using chaining operators like `&&` and `||`. To be fair, those did get added to PowerShell 7.0, but judging by `git blame` on the main `package.json`, those do predate PS 7.0 by several years. Unless NPM already does some special handling for those under Windows... I'll at least make a note in the contributing guide though.

👍 1

norm added 1 commit 2022-09-05 16:04:14 +00:00

Add note about development platform in contributing guide ca4f89564b

Johann150 referenced this pull request from a commit 2022-09-05 22:09:13 +00:00

merge: Use native shell commands for clean/clean-all

Johann150 manually merged commit 72b5da28e7 into main 2022-09-05 22:09:16 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#110

No description provided.