FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

sw: Remove fetch handler from service worker #116

Merged
norm merged 1 commit from Michcio/FoundKey-0x7f:fix/sw-remove-offlien into main 2022-09-07 08:10:07 +00:00
Conversation 0 Commits 1 Files changed 1 -7
Michcio commented 2022-09-06 21:28:05 +00:00
Contributor
Copy link

In current state, service worker overloads every "connection error"
kind of reaction to a plaintext 200 saying "Offline.", which leads
to terribly undebuggable situations as the browser decides to cache
this as an image, and then someone's pfp is broken literally
forever unless you Ctrl+Shift+R every time you reload frontend.

This change removes the handler, because it is unclear how we even
benefit from it being there.

In current state, service worker overloads every "connection error" kind of reaction to a plaintext 200 saying "Offline.", which leads to terribly undebuggable situations as the browser decides to cache this as an image, and then someone's pfp is broken literally forever unless you Ctrl+Shift+R every time you reload frontend. This change removes the handler, because it is unclear how we even benefit from it being there.
Michcio added 1 commit 2022-09-06 21:28:06 +00:00
sw: Remove fetch handler from service worker
Some checks failed
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
026941ce77 
In current state, service worker overloads every "connection error"
kind of reaction to a plaintext 200 saying "Offline.", which leads
to terribly undebuggable situations as the browser decides to cache
this as an image, and then someone's pfp is broken literally
forever unless you Ctrl+Shift+R every time you reload frontend.

This change removes the handler, because it is unclear how we even
benefit from it being there.
norm merged commit f51f900115 into main 2022-09-07 08:10:07 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#116
No description provided.
Delete branch "Michcio/FoundKey-0x7f:fix/sw-remove-offlien"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?