FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

ci: combine lint tasks #126

Closed
norm wants to merge 1 commit from ci/combine-lints into main
pull from: ci/combine-lints
merge into: FoundKeyGang:main
Conversation 4 Commits 1 Files changed 4 +52 -66
norm commented 2022-09-07 21:49:50 +00:00
Owner
Copy link

This allows for per-package lints to not require separate yarn install
steps.

The use of status: [ success, failure ] ensures that each step can run
even if the previous one failed.

Resolves #123

This allows for per-package lints to not require separate `yarn install` steps. The use of `status: [ success, failure ]` ensures that each step can run even if the previous one failed. Resolves https://akkoma.dev/FoundKeyGang/FoundKey/issues/123
toast commented 2022-09-08 00:46:27 +00:00
Owner
Copy link

A potentially better approach would be to cache yarn's cache dir + node_modules. That way we could have separate lints per thing (making them more useful) but not incur the perf penalty.

A potentially better approach would be to cache yarn's cache dir + node_modules. That way we could have separate lints per thing (making them more useful) but not incur the perf penalty.
norm force-pushed ci/combine-lints from 9653be8922 to b9d209be2a 2022-09-08 00:51:27 +00:00 Compare
norm commented 2022-09-08 00:54:38 +00:00
Author
Owner
Copy link

How would that be done?

How would that be done?
Johann150 commented 2022-09-08 20:34:29 +00:00
Owner
Copy link

Even if the other lints are run on failure of previous lints, it would be nice to have separate indicators for each of the lints. Because seeing which of the lints failed was the reason to separate them in the first place. This kinda makes it difficult if you have to scroll through all the existing lints to see if another module has new ones.

Ideally we would have a kind of "forking" workflow but I think I asked & searched for that before and it does not seem to be possible.

Even if the other lints are run on failure of previous lints, it would be nice to have separate indicators for each of the lints. Because seeing which of the lints failed was the reason to separate them in the first place. This kinda makes it difficult if you have to scroll through all the existing lints to see if another module has new ones. Ideally we would have a kind of "forking" workflow but I think I asked & searched for that before and it does not seem to be possible.
norm commented 2022-09-08 20:51:16 +00:00
Author
Owner
Copy link

Closing this as this doesn't seem to be the approach we'd want to take. Discussion is being continued in #123.

Closing this as this doesn't seem to be the approach we'd want to take. Discussion is being continued in https://akkoma.dev/FoundKeyGang/FoundKey/issues/123.
norm closed this pull request 2022-09-08 20:51:16 +00:00
norm deleted branch ci/combine-lints 2022-09-08 20:51:25 +00:00
Some checks failed
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#126
No description provided.
Delete branch "ci/combine-lints"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?