FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
20
Fork 23
Code Issues 37 Pull requests 3 Releases Activity

backend: fix types in boot/{master, worker}.ts #128

Merged
norm merged 1 commit from fix/backend-boot-types into main 2022-09-08 21:29:02 +00:00
Conversation 1 Commits 1 Files changed 2 +9 -8
norm commented 2022-09-08 05:38:49 +00:00
Contributor
Copy link
No description provided.
Johann150 approved these changes 2022-09-08 21:23:59 +00:00
Johann150 left a comment
Owner
Copy link

Looks good to me.

Looks good to me.
packages/backend/src/boot/worker.ts Outdated
@ -17,2 +16,3 @@
if (cluster.isWorker && process.send) {
// Send a 'ready' message to parent process
process.send!('ready');
process.send('ready');
Johann150 commented 2022-09-08 21:22:22 +00:00
Owner
Copy link

You could also use optional chaining for function calls here if you want, i.e.

process.send?.('ready');
You could also use [optional chaining for function calls](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining#optional_chaining_with_function_calls) here if you want, i.e. ```ts process.send?.('ready'); ```
norm marked this conversation as resolved
norm force-pushed fix/backend-boot-types from 5ab7c7bdc5
Some checks failed
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline failed
Details
to 29c7e7e859
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
2022-09-08 21:28:27 +00:00 Compare
norm merged commit 714ce60980 into main 2022-09-08 21:29:02 +00:00
norm deleted branch fix/backend-boot-types 2022-09-08 21:29:03 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#125 Eliminate type errors in backend
FoundKeyGang/FoundKey
Reference
FoundKeyGang/FoundKey!128
No description provided.