backend: fix types in boot/{master, worker}.ts #128

norm · 2022-09-08T05:38:49Z

norm commented

2022-09-08 05:38:49 +00:00

No description provided.

norm added a new dependency 2022-09-08 05:39:00 +00:00

#125 Eliminate type errors in backend

Johann150 approved these changes 2022-09-08 21:23:59 +00:00

Johann150 left a comment

Looks good to me.

packages/backend/src/boot/worker.ts Outdated

					
				@ -17,2 +16,3 @@

					if (cluster.isWorker && process.send) {

						// Send a 'ready' message to parent process

						process.send!('ready');

						process.send('ready');

Johann150 commented

2022-09-08 21:22:22 +00:00

You could also use optional chaining for function calls here if you want, i.e.

process.send?.('ready');

You could also use [optional chaining for function calls](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Optional_chaining#optional_chaining_with_function_calls) here if you want, i.e. ```ts process.send?.('ready'); ```

norm marked this conversation as resolved

norm force-pushed fix/backend-boot-types from 5ab7c7bdc5 to 29c7e7e859

2022-09-08 21:28:27 +00:00

Compare

norm merged commit 714ce60980 into main

2022-09-08 21:29:02 +00:00

norm referenced this pull request from a commit

2022-09-08 21:29:03 +00:00

Merge pull request 'backend: fix types in boot/{master, worker}.ts' (#128) from fix/backend-boot-types into main

norm deleted branch fix/backend-boot-types

2022-09-08 21:29:03 +00:00

Sign in to join this conversation.