FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

backend: Fix appendChildren TypeError #136

Merged
norm merged 1 commit from fix/backend-to-html-typeerror into main 2022-09-11 18:31:26 +00:00
Conversation 0 Commits 1 Files changed 1 +27 -24
norm commented 2022-09-10 00:58:20 +00:00
Owner
Copy link

In #134, the mention MfmNode handler was made async to allow the
mentionedUsers query to be used there. This however changed the return
type of that handler to be a Promise, causing a TypeError in
appendChildren.

This fixes the TypeError by making every handler and the appendChildren
function also async and awaiting on the processed children.

This also attempts to fix the types issue with handlers by casting to
the newly defined HandlerFunc type instead of to any.

In #134, the mention `MfmNode` handler was made async to allow the mentionedUsers query to be used there. This however changed the return type of that handler to be a `Promise`, causing a `TypeError` in `appendChildren`. This fixes the `TypeError` by making every handler and the `appendChildren` function also async and awaiting on the processed children. This also attempts to fix the types issue with handlers by casting to the newly defined `HandlerFunc` type instead of to `any`.
norm force-pushed fix/backend-to-html-typeerror from 19b4360e1c to 319ec40bd3 2022-09-10 01:21:34 +00:00 Compare
Johann150 approved these changes 2022-09-11 18:10:24 +00:00
Johann150 left a comment
Owner
Copy link

seems a quite important fix and also working. just one minor nitpick

seems a quite important fix and also working. just one minor nitpick
packages/backend/src/mfm/to-html.ts Outdated
@ -170,0 +167,4 @@
async function appendChildren(children: mfm.MfmNode[], targetElement: HTMLElement): Promise<void> {
type HandlerFunc = (node: mfm.MfmNode) => Promise<Node>;
const htmlChildren = await Promise.all(children.map(x => (handlers[x.type] as HandlerFunc)(x)));
Johann150 commented 2022-09-11 18:10:22 +00:00
Owner
Copy link
$ git diff --check
packages/backend/src/mfm/to-html.ts:170: trailing whitespace.
``` $ git diff --check packages/backend/src/mfm/to-html.ts:170: trailing whitespace. ```
norm commented 2022-09-11 18:28:09 +00:00
Author
Owner
Copy link

fixed.

fixed.
norm marked this conversation as resolved
norm force-pushed fix/backend-to-html-typeerror from e709902540 to ffa1954fb1 2022-09-11 18:28:01 +00:00 Compare
norm force-pushed fix/backend-to-html-typeerror from ffa1954fb1 to 9bcc247421 2022-09-11 18:29:47 +00:00 Compare
norm merged commit c926b4fbcc into main 2022-09-11 18:31:25 +00:00
norm deleted branch fix/backend-to-html-typeerror 2022-09-11 18:31:27 +00:00
norm referenced this pull request from a commit 2022-09-12 20:30:38 +00:00
backend: make toHtml tests async
norm referenced this pull request from a commit 2022-09-12 20:38:28 +00:00
backend: make toHtml tests async
norm referenced this pull request from a commit 2022-09-13 15:20:06 +00:00
backend: make toHtml tests async
norm referenced this pull request from a commit 2022-09-13 15:20:27 +00:00
backend: make toHtml tests async
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#136
No description provided.
Delete branch "fix/backend-to-html-typeerror"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?