FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

chore: Change Misskey references to Foundkey #142

Merged
norm merged 2 commits from chore/misskey-to-foundkey into main 2022-09-13 21:20:13 +00:00
Conversation 2 Commits 2 Files changed 64 +607 -705
norm commented 2022-09-11 04:23:34 +00:00
Owner
Copy link

Closes #141

Not really sure about a few things like the logo displayed in the server console and the list of "main contributors".

Closes https://akkoma.dev/FoundKeyGang/FoundKey/issues/141 Not really sure about a few things like the logo displayed in the server console and the list of "main contributors".
norm force-pushed chore/misskey-to-foundkey from 70a659ce7b to a1cb40f442 2022-09-11 04:34:29 +00:00 Compare
norm force-pushed chore/misskey-to-foundkey from a1cb40f442 to 1cc4b4d1b0 2022-09-11 21:16:13 +00:00 Compare
norm commented 2022-09-11 21:26:56 +00:00
Author
Owner
Copy link

This is what the FoundKey ASCII logo in the server logs should look like without all of the escaping:
image

This is what the FoundKey ASCII logo in the server logs should look like without all of the escaping: ![image](/attachments/d4adeaa3-09f0-47a7-92e5-de836e76fc8f)
image.png
5.9 KiB
norm force-pushed chore/misskey-to-foundkey from a979a10ebe to c4646b984f 2022-09-11 21:49:52 +00:00 Compare
norm force-pushed chore/misskey-to-foundkey from 29c862f79a to 641e51b65e 2022-09-11 23:41:01 +00:00 Compare
norm force-pushed chore/misskey-to-foundkey from 641e51b65e to 64eb8946f2 2022-09-12 15:52:53 +00:00 Compare
norm force-pushed chore/misskey-to-foundkey from 4314057871 to 21e5d51b6a 2022-09-12 16:22:02 +00:00 Compare
norm force-pushed chore/misskey-to-foundkey from da4ce8aa62 to cb49627b89 2022-09-12 21:29:10 +00:00 Compare
norm force-pushed chore/misskey-to-foundkey from cb49627b89 to fb5f55caa2 2022-09-12 21:54:20 +00:00 Compare
norm force-pushed chore/misskey-to-foundkey from 261fb94781 to 9d11c8ab91 2022-09-12 22:06:51 +00:00 Compare
norm force-pushed chore/misskey-to-foundkey from 9d11c8ab91 to 928eb74752 2022-09-12 22:11:03 +00:00 Compare
norm changed title from WIP: chore: Change Misskey references to Foundkey to chore: Change Misskey references to Foundkey 2022-09-12 22:11:46 +00:00
norm commented 2022-09-12 22:12:22 +00:00
Author
Owner
Copy link

I think this is about as much as I'm willing to do in this PR, barring of course any sort of nitpicks or major issues.

I think this is about as much as I'm willing to do in this PR, barring of course any sort of nitpicks or major issues.
norm force-pushed chore/misskey-to-foundkey from 928eb74752 to 6d4123b844 2022-09-13 00:15:49 +00:00 Compare
norm force-pushed chore/misskey-to-foundkey from 69e0829430 to f951a98471 2022-09-13 15:19:34 +00:00 Compare
Johann150 approved these changes 2022-09-13 15:54:21 +00:00
packages/backend/src/remote/activitypub/renderer/index.ts Outdated
@ -32,3 +32,3 @@
PropertyValue: 'schema:PropertyValue',
value: 'schema:value',
// Misskey
// FoundKey
Johann150 commented 2022-09-13 15:37:28 +00:00
Owner
Copy link

Not that it matters much, but this part indeed is Misskey, not Foundkey.

Not that it matters much, but this part indeed is Misskey, not Foundkey.
norm marked this conversation as resolved
packages/backend/src/server/api/service/discord.ts Outdated
@ -190,3 +190,3 @@
if (profile == null) {
ctx.throw(404, `@${username}#${discriminator}と連携しているMisskeyアカウントはありませんでした...`);
ctx.throw(404, `There were no FoundKey accounts linked to @${username}#${discriminator}...`);
Johann150 commented 2022-09-13 15:38:40 +00:00
Owner
Copy link

Maybe these strings should use locale management. Are they user visible?

Maybe these strings should use locale management. Are they user visible?
norm commented 2022-09-13 16:00:09 +00:00
Author
Owner
Copy link

Are they user visible?

Not really sure.

> Are they user visible? Not really sure.
norm marked this conversation as resolved
norm force-pushed chore/misskey-to-foundkey from 43193c41be to 7b4253df79 2022-09-13 17:19:47 +00:00 Compare
Johann150 approved these changes 2022-09-13 17:57:38 +00:00
Johann150 left a comment
Owner
Copy link

I'd say fixing the nitpick is optional if you want. Looks good to me.

I'd say fixing the nitpick is optional if you want. Looks good to me.
packages/backend/src/server/api/service/discord.ts Outdated
@ -277,1 +284,3 @@
ctx.body = `Discord: @${username}#${discriminator} を、Misskey: @${user.username} に接続しました！`;
ctx.body = i18n.t('_services._discord.connected', {
discordUserName: username,
discordDiscriminator: discriminator,
Johann150 commented 2022-09-13 17:56:38 +00:00
Owner
Copy link

To make it perfect you could have named them username and discriminator to use the object shorthand. But this works perfectly fine too.

To make it perfect you could have named them `username` and `discriminator` to use the object shorthand. But this works perfectly fine too.
norm marked this conversation as resolved
norm force-pushed chore/misskey-to-foundkey from 7b4253df79 to e507b1b888 2022-09-13 21:19:22 +00:00 Compare
norm merged commit 3cbdac7621 into main 2022-09-13 21:20:13 +00:00
norm deleted branch chore/misskey-to-foundkey 2022-09-13 21:20:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#142
No description provided.
Delete branch "chore/misskey-to-foundkey"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?