FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

client: add margins around buttons and switches #157

Closed
norm wants to merge 1 commit from button-margins into main
pull from: button-margins
merge into: FoundKeyGang:main
Conversation 0 Commits 1 Files changed 2 +7 -5
norm commented 2022-09-16 01:02:22 +00:00
Owner
Copy link

In some places like the notification settings, the buttons and switches
are squished together, which doesn't really look that great.

Also renamed the CSS class names for these components to be in the form
of {dir}-{componentName}, where {dir} is relative to the components
directory.

In some places like the notification settings, the buttons and switches are squished together, which doesn't really look that great. Also renamed the CSS class names for these components to be in the form of `{dir}-{componentName}`, where `{dir}` is relative to the components directory.
norm added 1 commit 2022-09-16 01:02:23 +00:00
client: add margins around buttons and switches
Some checks failed
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
3f5450b503 
In some places like the notification settings, the buttons and switches
are squished together, which doesn't really look that great.

Also renamed the CSS class names for these components to be in the form
of `{dir}-{componentName}`, where `{dir}` is relative to the components
directory.
norm closed this pull request 2022-09-26 19:17:50 +00:00
norm deleted branch button-margins 2022-09-26 19:17:53 +00:00
Some checks failed
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#157
No description provided.
Delete branch "button-margins"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?