FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

fix: broken chats #16

Manually merged
Johann150 merged 3 commits from :fix-chat-continuation into main 2022-07-19 07:21:17 +00:00
Conversation 0 Commits 3 Files changed 2 +18 -18
2 changed files with 18 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

30
packages/client/src/components/ui/pagination.vue
View file

@ -180,21 +180,23 @@ const prepend = (item: Item): void => {
if (props.pagination.reversed) {
if (rootEl.value) {
const container = getScrollContainer(rootEl.value);
if (container == null) return; // TODO?
const pos = getScrollPosition(rootEl.value);
const viewHeight = container.clientHeight;
const height = container.scrollHeight;
const isBottom = (pos + viewHeight > height - 32);
if (isBottom) {
// オーバーフローしたら古いアイテムは捨てる
if (items.value.length >= props.displayLimit) {
// このやり方だとVue 3.2以降アニメーションが動かなくなる
//items.value = items.value.slice(-props.displayLimit);
while (items.value.length >= props.displayLimit) {
items.value.shift();
if (container == null) {
// TODO?
} else {
const pos = getScrollPosition(rootEl.value);
const viewHeight = container.clientHeight;
const height = container.scrollHeight;
const isBottom = (pos + viewHeight > height - 32);
if (isBottom) {
// オーバーフローしたら古いアイテムは捨てる
if (items.value.length >= props.displayLimit) {
// このやり方だとVue 3.2以降アニメーションが動かなくなる
//items.value = items.value.slice(-props.displayLimit);
while (items.value.length >= props.displayLimit) {
items.value.shift();
}
more.value = true;
}
more.value = true;
}
}
}

6
packages/client/src/pages/messaging/messaging-room.vue
View file

@ -292,6 +292,7 @@ definePageMetadata(computed(() => !fetching ? user ? {
<style lang="scss" scoped>
.mk-messaging-room {
position: relative;
overflow: auto;
Johann150 marked this conversation as resolved
Johann150 commented 2022-07-19 07:15:48 +00:00
Review
Copy link

I think using overflow-y here is a better idea. Otherwise browsers will always show an unnecessary scroll bar for horizontal scrolling.

Or maybe use overflow: auto; instead to let the browser decide when scroll bars are necessary.
-- https://github.com/misskey-dev/misskey/pull/8951#discussion_r915101719

> I think using `overflow-y` here is a better idea. Otherwise browsers will always show an unnecessary scroll bar for horizontal scrolling. > > Or maybe use `overflow: auto;` instead to let the browser decide when scroll bars are necessary. -- https://github.com/misskey-dev/misskey/pull/8951#discussion_r915101719
Johann150 commented 2022-07-19 07:18:25 +00:00
Review
Copy link

Hang on that already says overflow auto...

Hang on that already says overflow auto...
> .body {
.more {
@ -335,10 +336,7 @@ definePageMetadata(computed(() => !fetching ? user ? {
z-index: 2;
bottom: 0;
padding-top: 8px;
@media (max-width: 500px) {
bottom: calc(env(safe-area-inset-bottom, 0px) + 92px);
}
bottom: calc(env(safe-area-inset-bottom, 0px) + 8px);
> .new-message {
width: 100%;