Revert "Use native shell commands for clean/clean-all" #170

Merged

norm merged 3 commits from revert-native-clean into main 2022-09-23 22:15:30 +00:00

Conversation 4 Commits 3 Files changed 7 +30 -13

norm commented 2022-09-22 19:10:39 +00:00

Owner

Copy link

This reverts commit 5fb294e7d7.

This will allow the clean/clean-all command to work on Windows once again.

Doing a bit of additional reseearch, I learned that the && and || operators do work on Windows since node uses cmd.exe and not Powershell like I initially thought.

This reverts commit 5fb294e7d7c3cc4e638993659644923b200cefae. This will allow the clean/clean-all command to work on Windows once again. Doing a bit of additional reseearch, I learned that the `&&` and `||` operators do work on Windows since node uses `cmd.exe` and not Powershell like I initially thought.

norm added 1 commit 2022-09-22 19:10:40 +00:00

Revert "Use native shell commands for clean/clean-all" ... d9a64d0a22

This reverts commit 5fb294e7d7.

This will allow the clean/clean-all command to work on Windows once again.

Michcio commented 2022-09-23 08:54:38 +00:00

Contributor

Copy link

If you are using rmSync, why are you putting it in async closures?

If you are using rmSync, why are you putting it in async closures?

norm commented 2022-09-23 12:40:21 +00:00

Author

Owner

Copy link

That's what the original scripts did. Maybe I'll look at using the fs/promises api instead

That's what the original scripts did. Maybe I'll look at using the `fs/promises` api instead

Michcio commented 2022-09-23 12:58:56 +00:00

Contributor

Copy link

Tbh promises or not, you just don't have to wrap it in a function execution I think? Cause there's nothing asynchronous here

Tbh promises or not, you just don't have to wrap it in a function execution I think? Cause there's nothing asynchronous here

norm commented 2022-09-23 13:57:04 +00:00

Author

Owner

Copy link

fair, I'm just gonna remove the async wrapper stuff for now

fair, I'm just gonna remove the async wrapper stuff for now

norm added 1 commit 2022-09-23 15:02:40 +00:00

Make clean scripts non-async ... b90f910926

Since they use rmSync, the async stuff doesn't really do anything useful.

norm added 1 commit 2022-09-23 15:48:54 +00:00

Remove 'recursive: true' from removing tsbuildinfo fa0dce6439

norm merged commit 9470e12424 into main 2022-09-23 22:15:30 +00:00

norm deleted branch revert-native-clean 2022-09-23 22:15:30 +00:00

norm referenced this pull request from a commit 2022-09-23 22:15:30 +00:00

Merge pull request 'Revert "Use native shell commands for clean/clean-all"' (#170) from revert-native-clean into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#170

No description provided.