FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

refactor: media-caption component as composition api #21

Merged
Johann150 merged 3 commits from :refactor/media-caption into main 2022-07-23 20:23:45 +00:00
Conversation 0 Commits 3 Files Changed 1 +85 -111
norm commented 2022-07-22 03:17:30 +00:00
Owner
Copy Link

Eslint will complain that DriveFile doesn't have a comment property. I have a patch for misskey.js to fix that here: 28f244479c

Eslint will complain that `DriveFile` doesn't have a `comment` property. I have a patch for misskey.js to fix that here: https://akkoma.dev/norm/foundkey.js/commit/28f244479cecaa9ed854f8edea054234ff3ba394
norm added 1 commit 2022-07-22 03:17:30 +00:00
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/test Pipeline failed Details
ci/woodpecker/pr/lint-client Pipeline failed Details
f4df03fb78
refactor: media-caption component as composition api
Johann150 reviewed 2022-07-22 06:28:06 +00:00
packages/client/src/components/media-caption.vue Outdated
@ -12,3 +2,1 @@
<MkButton inline primary :disabled="remainingLength < 0" @click="ok">{{ $ts.ok }}</MkButton>
<MkButton inline @click="cancel" >{{ $ts.cancel }}</MkButton>
</div>
<MkModal ref="modal" @click="done(true)" @closed="$emit('closed')">
Johann150 commented 2022-07-22 06:28:06 +00:00
Owner
Copy Link

This should also use emit.

This should also use `emit`.
norm marked this conversation as resolved
norm added 1 commit 2022-07-22 09:33:10 +00:00
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
c9925a7e89
refactor: use emit for MkModal @closed
norm added 1 commit 2022-07-23 20:10:51 +00:00
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
4d6e3d4cd7 remove async from ok()
Johann150 merged commit bbb16208ab into main 2022-07-23 20:23:45 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#21
No description provided.
Delete Branch ":refactor/media-caption"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?