FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

backend: make max note length configurable #210

Merged
norm merged 3 commits from configurable-max-note-text-length into main 2022-10-18 17:33:00 +00:00
Conversation 1 Commits 3 Files changed 8 +14 -11
norm commented 2022-10-17 21:58:09 +00:00
Owner
Copy link

Changelog: Added
Closes: #208

Changelog: Added Closes: https://akkoma.dev/FoundKeyGang/FoundKey/issues/208
norm added 1 commit 2022-10-17 21:58:09 +00:00
backend: make max note length configurable
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
96fd2eec1c 
Changelog: Added
Closes: #208
norm added 1 commit 2022-10-17 22:00:00 +00:00
translate comments
Some checks failed
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
5999eec418
toast commented 2022-10-17 22:05:09 +00:00
Owner
Copy link

LGTM but I haven't tested
tired out for today

LGTM but I haven't tested tired out for today
Johann150 reviewed 2022-10-18 15:18:57 +00:00
Johann150 left a comment
Owner
Copy link

small nitpick

small nitpick
packages/backend/src/server/api/endpoints/admin/meta.ts Outdated
@ -310,7 +309,7 @@ export default define(meta, paramDef, async (ps, me) => {
iconUrl: instance.iconUrl,
backgroundImageUrl: instance.backgroundImageUrl,
logoImageUrl: instance.logoImageUrl,
maxNoteTextLength: MAX_NOTE_TEXT_LENGTH, // 後方互換性のため
Johann150 commented 2022-10-18 15:13:58 +00:00
Owner
Copy link

Since this is now "officially" variable again I'd remove the comment here.

Since this is now "officially" variable again I'd remove the comment here.
norm marked this conversation as resolved
packages/backend/src/server/api/endpoints/meta.ts Outdated
@ -312,3 +311,3 @@
backgroundImageUrl: instance.backgroundImageUrl,
logoImageUrl: instance.logoImageUrl,
maxNoteTextLength: MAX_NOTE_TEXT_LENGTH, // 後方互換性のため
maxNoteTextLength: config.maxNoteTextLength, // For backward compatibility
Johann150 commented 2022-10-18 15:14:16 +00:00
Owner
Copy link

as above

as above
norm marked this conversation as resolved
Johann150 added a new dependency 2022-10-18 15:21:19 +00:00
#208 Make note character limit configurable
norm added 1 commit 2022-10-18 16:10:42 +00:00
remove backwards compat comment
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
e25849143a
Johann150 approved these changes 2022-10-18 17:30:35 +00:00
norm merged commit 7257338077 into main 2022-10-18 17:33:00 +00:00
norm deleted branch configurable-max-note-text-length 2022-10-18 17:33:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks
#208 Make note character limit configurable}
FoundKeyGang/FoundKey
Reference: FoundKeyGang/FoundKey#210
No description provided.
Delete branch "configurable-max-note-text-length"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?