FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

refactor client to use native Notifications API (v2) #234

Manually merged
norm merged 5 commits from native-notifications into main 2022-11-29 17:38:46 +00:00
Conversation 1 Commits 5 Files changed 4 +20 -104
Johann150 commented 2022-11-12 20:25:37 +00:00
Owner
Copy link

This refactors the client to always use the native notification API even if push notifications are not enabled and/or you currently have Foundkey open.

Follow up from #219.

This refactors the client to always use the native notification API even if push notifications are not enabled and/or you currently have Foundkey open. Follow up from #219.
Johann150 added this to the (deleted) project 2022-11-12 20:25:48 +00:00
Johann150 force-pushed native-notifications from 45ee9951dc to 24506ba557 2022-11-26 15:41:14 +00:00 Compare
norm approved these changes 2022-11-29 17:28:38 +00:00
norm left a comment
Owner
Copy link

Works for me.

Works for me.
norm manually merged commit 5b574d40f9 into main 2022-11-29 17:38:46 +00:00
norm deleted branch native-notifications 2022-11-29 17:39:34 +00:00
Johann150 commented 2022-11-29 20:57:09 +00:00
Author
Owner
Copy link

Would probably be a good idea to also merge #235, otherwise instances where the admin hasn't set up the service worker won't get the notification toast any more but also not get native notifications.

Would probably be a good idea to also merge #235, otherwise instances where the admin hasn't set up the service worker won't get the notification toast any more but also not get native notifications.
👍 1
Johann150 added the
fix
 label 2022-12-23 10:18:53 +00:00
Johann150 removed this from the (deleted) project 2022-12-23 10:18:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
norm
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#234
No description provided.
Delete branch "native-notifications"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?