FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

server: Add recursion limit to resolver #261

Merged
norm merged 3 commits from recursion-limit into main 2022-12-01 20:11:41 +00:00
Conversation 0 Commits 3 Files Changed 4 +13 -9
norm commented 2022-12-01 09:39:52 +00:00
Owner
Copy Link

Patches pulled from https://code.vtopia.live/Vtopia/MissV/pulls/8

This mitigates an attack where an actor object can recursively reference randomly generated actors, which can cause the instance to slow to a crawl.

Patches pulled from https://code.vtopia.live/Vtopia/MissV/pulls/8 This mitigates an attack where an actor object can recursively reference randomly generated actors, which can cause the instance to slow to a crawl.
norm force-pushed recursion-limit from dab5efbc02 to 11a6e706f4 2022-12-01 09:40:20 +00:00 Compare
Johann150 added 1 commit 2022-12-01 19:34:09 +00:00
ci/woodpecker/push/lint-client Pipeline was successful Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/test Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline failed Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
936cbf900b
use default argument value 
This unifies the style with the other function in that file and fixes
the lint "no-param-reassign".
Johann150 approved these changes 2022-12-01 19:35:59 +00:00
Johann150 left a comment
Owner
Copy Link

Looks good to me now.

Looks good to me now.
norm merged commit dc7533baa4 into main 2022-12-01 20:11:41 +00:00
norm deleted branch recursion-limit 2022-12-01 20:11:41 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#261
No description provided.
Delete Branch "recursion-limit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?