refactor away as many "new Resolver" as possible #271

Manually merged

Johann150 merged 3 commits from refactor/resolver into main 2022-12-04 20:13:54 +00:00

Conversation 0 Commits 3 Files changed 19 +138 -163

Johann150 commented 2022-12-03 23:39:29 +00:00

Owner

Copy link

Replaces #270. Closes #264.

Replaces #270. Closes #264.

Johann150 added 2 commits 2022-12-03 23:39:29 +00:00

server: refactor "authUser" functions into separate file ... b2fb4bffca

They did not really fit into the DbResolver because they may fetch data
from remote instances even though DbResolver is only supposed to access
the database.

server: refactor resolveSelf to just return the webfinger href ... 77bfe74645

Since the href seems to be the only attribute that is used, and I didn't
want to add a full type definition this was the easier option.

norm referenced this pull request 2022-12-04 00:23:31 +00:00

server: Actually fix forkbomb exploit #270

Johann150 force-pushed refactor/resolver from 0a55e89c7a to 1670d3a10a 2022-12-04 02:45:23 +00:00 Compare

norm approved these changes 2022-12-04 17:18:09 +00:00

Johann150 manually merged commit a421dd401c into main 2022-12-04 20:13:54 +00:00

Johann150 deleted branch refactor/resolver 2022-12-04 20:14:05 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

norm

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No labels

feature

fix

upkeep

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#271

No description provided.