FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

Remove integrations #273

Manually merged
Johann150 merged 12 commits from feature/remove-integration into main 2022-12-07 16:18:25 +00:00
Conversation 1 Commits 12 Files changed 48 +34 -1507
pixeldesu commented 2022-12-06 21:10:16 +00:00
Owner
Copy link

@Johann150 listed all Foundkey servers that currently have any integration enabled and it turns out that it is not many, extending this test to Misskey would probably yield most of the servers not supporting it either.

The implementation is a bit weird (only sign in, no sign up is supported) and not really documented or explained well in the admin panel either, probably leading to its low adoption in the first place.

This Pull Request removes everything related to integrations.

@Johann150 [listed all Foundkey servers that currently have any integration enabled](https://genau.qwertqwefsday.eu/@Johann150/pages/2022-12-06-integrations) and it turns out that it is not many, extending this test to Misskey would probably yield most of the servers not supporting it either. The implementation is a bit weird (only sign in, no sign up is supported) and not really documented or explained well in the admin panel either, probably leading to its low adoption in the first place. This Pull Request removes everything related to integrations.
pixeldesu added 8 commits 2022-12-06 21:10:17 +00:00
locales: remove integration-related locales
Some checks failed
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline failed
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
87e1e658f2
Johann150 requested changes 2022-12-06 21:42:01 +00:00
Johann150 left a comment
Owner
Copy link

Found some small nitpicks.

Found some small nitpicks.
packages/backend/src/remote/activitypub/models/person.ts Outdated
@ -418,4 +404,0 @@
}
};
function addService(target: { [x: string]: any }, source: IApPropertyValue) {
Johann150 commented 2022-12-06 21:20:06 +00:00
Owner
Copy link

Remove unused import of IApPropertyValue.

Remove unused import of `IApPropertyValue`.
Johann150 marked this conversation as resolved
packages/backend/src/server/api/service/discord.ts Outdated
@ -1,294 +0,0 @@
import Koa from 'koa';
import Router from '@koa/router';
import { OAuth2 } from 'oauth';
Johann150 commented 2022-12-06 21:26:36 +00:00
Owner
Copy link

The oauth package seems to be unused now so can be removed.

The `oauth` package seems to be unused now so can be removed.
pixeldesu commented 2022-12-06 22:26:34 +00:00
Author
Owner
Copy link

removed @types/oauth and autwh (since latter actually gets us the oauth dependency)

removed `@types/oauth` and `autwh` (since latter actually gets us the `oauth` dependency)
Johann150 marked this conversation as resolved
pixeldesu added 2 commits 2022-12-06 22:00:51 +00:00
client: remove integration settings menu entry
Some checks failed
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline failed
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
96c3744555
pixeldesu added 2 commits 2022-12-06 22:18:44 +00:00
chore: remove unused packages
Some checks failed
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline failed
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
d3f1ad9a88
pixeldesu requested review from Johann150 2022-12-06 22:22:29 +00:00
norm commented 2022-12-06 22:26:53 +00:00
Owner
Copy link

You'll need to also remove all of the _services locales in en-US.yml since those are obviously not used anymore.

Nvm, seems like you did it.

~~You'll need to also remove all of the `_services` locales in `en-US.yml` since those are obviously not used anymore.~~ Nvm, seems like you did it.
Johann150 approved these changes 2022-12-07 16:09:28 +00:00
Johann150 manually merged commit 71b976ec96 into main 2022-12-07 16:18:25 +00:00
Johann150 deleted branch feature/remove-integration 2022-12-07 16:18:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#273
No description provided.
Delete branch "feature/remove-integration"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?