FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

client: refactor tooltip directive #295

Manually merged
Johann150 merged 2 commits from refactor/tooltip into main 2022-12-23 10:07:21 +00:00
Conversation 0 Commits 2 Files changed 1 +81 -62
Johann150 commented 2022-12-22 13:15:26 +00:00
Owner
Copy link

Using the beforeUnmount hook should hopefully improve issues with tooltips being left behind, as described in #120.

I'm not sure if this completely fixes that issue, and kinda hard to test since it only occurs sporadically.

Using the `beforeUnmount` hook should hopefully improve issues with tooltips being left behind, as described in #120. I'm not sure if this completely fixes that issue, and kinda hard to test since it only occurs sporadically.
Johann150 added 1 commit 2022-12-22 13:15:27 +00:00
client: refactor tooltip directive
Some checks failed
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-sw Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/lint-backend Pipeline failed
Details
ci/woodpecker/pr/build Pipeline failed
Details
ci/woodpecker/pr/lint-sw Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
ddf3e2c3db 
Using the beforeUnmount hook should hopefully improve issues with
tooltips being left behind.
norm reviewed 2022-12-22 21:24:23 +00:00
packages/client/src/directives/tooltip.ts Outdated
@ -29,0 +34,4 @@
this._close?.();
this._close = null;
}, delay);
},
norm commented 2022-12-22 21:24:23 +00:00
Owner
Copy link

Build fails due to a trailing comma.

Build fails due to a trailing comma.
Johann150 marked this conversation as resolved
Johann150 added 1 commit 2022-12-23 01:31:12 +00:00
fixup: confusing commas
Some checks failed
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-sw Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline failed
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-sw Pipeline failed
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details
e8e82dac82
norm approved these changes 2022-12-23 02:09:58 +00:00
Johann150 manually merged commit 79ddbafd0d into main 2022-12-23 10:07:21 +00:00
Johann150 deleted branch refactor/tooltip 2022-12-23 10:07:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
norm
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#295
No description provided.
Delete branch "refactor/tooltip"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?