fix user deletion race condition (v2) #333

Manually merged

Johann150 merged 3 commits from user-deletion into main 2023-05-23 19:50:51 +00:00

Conversation 1 Commits 3 Files Changed 16 +82 -33

Johann150 commented 2023-02-01 22:36:03 +00:00

Owner

Copy Link

Things to fix from the revert commit (bb3ec8bafe)

• multiple type errors
• breaks outgoing note federation (in at least two ways)
• a foreign key incompatibility (?)

Things to fix from the revert commit (bb3ec8bafe5d16eea061929271f72032c8aeb6f3) - [x] multiple type errors - [x] breaks outgoing note federation (in at least two ways) - ~~a foreign key incompatibility (?)~~

toast commented 2023-02-12 00:51:23 +00:00

Owner

Copy Link

Ok so I dug through the stuff a bit but I couldn't find the specific error.
Tl;dr with this migration there was a foreign key that was failing to cascade because one foreign key close was reversed.
I.e you have to delete A before you can delete B (we were trying to delete B without deleting A).
I'm quite sad I couldn't find it though :(
I might try to look again next time I have some free time.

Ok so I dug through the stuff a bit but I couldn't find the specific error. Tl;dr with this migration there was a foreign key that was failing to cascade because one foreign key close was reversed. I.e you have to delete A before you can delete B (we were trying to delete B without deleting A). I'm quite sad I couldn't find it though :( I might try to look again next time I have some free time.

Johann150 force-pushed user-deletion from b3bb59e4fd to 22eed66cbd 2023-03-11 20:27:34 +00:00 Compare

Johann150 changed title from WIP: fix user deletion race condition (v2) to fix user deletion race condition (v2) 2023-03-11 20:27:46 +00:00

Johann150 force-pushed user-deletion from 22eed66cbd to f5509c58d8 2023-05-01 10:50:48 +00:00 Compare

Johann150 force-pushed user-deletion from f5509c58d8 to 4867874800 2023-05-23 19:25:48 +00:00 Compare

Johann150 manually merged commit 4307010a9f into main 2023-05-23 19:50:51 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

feature

task that proposes new feature(s)

  

fix

task to fix behavioral problems in the FoundKey codebase

  

upkeep

task that should make FoundKey smaller and more maintainable

No Label

feature

fix

upkeep

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#333

No description provided.