FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

markdown for pages #338

Open
Johann150 wants to merge 20 commits from markdown into main
pull from: markdown
merge into: FoundKeyGang:main
Conversation 0 Commits 20 Files Changed 11 +891 -127
Johann150 commented 2023-02-05 22:48:49 +00:00
Owner
Copy Link

working towards #1

bugs noted from @toast's test page:

  • line breaks and HTML entities are not properly displayed in inline code and code blocks
  • if a link label contains a line break, the line break is not displayed. it should be displayed as whitespace (e.g. U+0020)
working towards #1 - [ ] replace emoji with Twemoji see also #301, so maybe just in general detect Unicode emoji - [ ] missing feature from MFM: links that don't generate previews with `?[asdf](https://example.com)` syntax see also https://socialhub.activitypub.rocks/t/mark-up-links-as-not-generating-a-preview/2978 bugs noted from @toast's [test page](https://mk.toast.cafe/@tost/pages/commonmark-0.30): - [x] line breaks and HTML entities are not properly displayed in inline code and code blocks - [x] if a link label contains a line break, the line break is not displayed. it should be displayed as whitespace (e.g. U+0020)
Johann150 added the
feature
 label 2023-02-05 22:48:49 +00:00
Johann150 changed title from WIP: markdown for pages to markdown for pages 2023-02-18 11:54:19 +00:00
Johann150 added this to the replace MFM with HTML milestone 2023-02-18 19:19:22 +00:00
toast force-pushed markdown from 14dcec1c54 to 72f3452060 2023-03-05 00:10:55 +00:00 Compare
Johann150 force-pushed markdown from 72f3452060 to 6f83bd8b0a 2023-03-24 19:47:31 +00:00 Compare
Johann150 force-pushed markdown from 6f83bd8b0a to 56e1528077 2023-03-24 20:19:18 +00:00 Compare
Johann150 force-pushed markdown from 56e1528077 to ebfdc0ffe3 2023-05-27 18:17:30 +00:00 Compare
All checks were successful
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-sw Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-sw Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
This pull request has changes conflicting with the target branch.
  • packages/client/package.json
  • packages/client/src/components/mfm.ts
  • yarn.lock
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b markdown main
git pull origin markdown

Step 2:

Merge the changes and update on Forgejo.
git checkout main
git merge --no-ff markdown
git push origin main
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
replace MFM with HTML
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#338
No description provided.
Delete Branch "markdown"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?