FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

additional detection with mime-types for module files #344

Manually merged
Johann150 merged 2 commits from puniko/FoundKey:improve/mime-types-detect-for-tracked-music into main 2023-02-19 14:06:20 +00:00
Conversation 0 Commits 2 Files Changed 2 +13 -2
puniko commented 2023-02-19 09:33:47 +00:00
Contributor
Copy Link

Additionally uses mime-types to detect modules. as npm's file-type doesn't know a lot of module types, this only seems to work with .xm, .it and .s3m files.

this should make detection a bit more reliable for those files from remote misskey-based instances

Additionally uses mime-types to detect modules. as npm's file-type doesn't know a lot of module types, this only seems to work with .xm, .it and .s3m files. this should make detection a bit more reliable for those files from remote misskey-based instances
puniko added 1 commit 2023-02-19 09:33:47 +00:00
ci/woodpecker/pr/lint-foundkey-js Pipeline failed Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/lint-backend Pipeline failed Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-sw Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
eb6dbca9fd additional detection with mime-types in module tracker
Johann150 reviewed 2023-02-19 13:00:49 +00:00
packages/client/src/components/media-list.vue Outdated
@ -131,3 +131,3 @@
const isModule = (file: foundkey.entities.DriveFile): boolean => {
return FILE_EXT_TRACKER_MODULES.some((ext) => {
return FILE_TYPE_TRACKER_MODULES.some((type) => {
Johann150 commented 2023-02-19 13:00:49 +00:00
Owner
Copy Link

I think you should use includes in this case.

I think you should use `includes` in this case.
puniko marked this conversation as resolved
puniko added 1 commit 2023-02-19 14:01:50 +00:00
ci/woodpecker/pr/lint-foundkey-js Pipeline failed Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/lint-backend Pipeline failed Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-sw Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
4de0b4e4ca use includes instead of some
Johann150 manually merged commit 3acf127e1d into main 2023-02-19 14:06:20 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#344
No description provided.
Delete Branch "puniko/FoundKey:improve/mime-types-detect-for-tracked-music"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?