FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

Lessen the sound pollution #394

Manually merged
Johann150 merged 1 commit from jeder/FoundKey:sound-pollution into main 2023-06-09 16:01:00 +00:00
Conversation 1 Commits 1 Files changed 1 +2 -2
jeder commented 2023-06-08 17:32:56 +00:00
Contributor
Copy link

Another smol PR I got an idea for while sitting with Mar and Miya
Make of it what you will, I thought it can save few clicks since I am not sure how many people even use these sounds unironically, I just find them very annoying

Another smol PR I got an idea for while sitting with Mar and Miya Make of it what you will, I thought it can save few clicks since I am not sure how many people even use these sounds unironically, I just find them very annoying
jeder added 1 commit 2023-06-08 17:32:57 +00:00
lessen the sound pollution
All checks were successful
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-sw Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline was successful
Details
42c6220126
Johann150 commented 2023-06-09 15:58:04 +00:00
Owner
Copy link

I agree that the sound for every new note received is excessive. I think setting the volume to 0 should be enough so people who do want it can turn it back on easily.

I think having some feedback when a note is sent is a good idea though so I think that should stay. If you don't want that for yourself, you can of course turn it off since these are only the default values.

I agree that the sound for every new note received is excessive. I think setting the volume to `0` should be enough so people who *do* want it can turn it back on easily. I think having some feedback when a note is sent is a good idea though so I think that should stay. If you don't want that for yourself, you can of course turn it off since these are only the default values.
Johann150 manually merged commit 777b981bf1 into main 2023-06-09 16:01:00 +00:00
jeder deleted branch sound-pollution 2023-06-19 18:51:17 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#394
No description provided.
Delete branch "jeder/FoundKey:sound-pollution"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?