FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

fix: lint errors in modal.vue #40

Merged
toast merged 1 commits from :fix/modal.vue into main 2022-07-29 12:10:19 +00:00
Conversation 2 Commits 1 Files Changed 1 +2 -2
norm commented 2022-07-28 19:48:01 +00:00
Owner
Copy Link
No description provided.
norm added 1 commit 2022-07-28 19:48:02 +00:00
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline failed Details
ci/woodpecker/push/test Pipeline failed Details
86b94e213e
fix: lint errors in modal.vue
toast merged commit 86b94e213e into main 2022-07-29 12:10:19 +00:00
norm deleted branch fix/modal.vue 2022-07-29 16:16:50 +00:00
Johann150 commented 2022-07-30 18:38:40 +00:00
Owner
Copy Link

Not sure why the change in line 34 was necessary? I thought the parameter being optional (as witnessed by the question mark after its name) should mean that it can be undefined. It should probably not be null. There was also no lint complaining about it that I could find. (I checked in this woodpecker run.)

Not sure why the change in line 34 was necessary? I thought the parameter being optional (as witnessed by the question mark after its name) should mean that it can be undefined. It should probably not be `null`. There was also no lint complaining about it that I could find. (I checked in [this woodpecker run](https://ci.akkoma.dev/FoundKeyGang/FoundKey/build/76/13).)
norm commented 2022-07-30 20:46:35 +00:00
Author
Owner
Copy Link

Probably was something that vscode was complaining to me about. Feel free to remove that.

Probably was something that vscode was complaining to me about. Feel free to remove that.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#40
No description provided.
Delete Branch ":fix/modal.vue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?