FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

activitypub: fix typo in audience.ts isPublic check #406

Manually merged
Johann150 merged 1 commits from zotan/FoundKey:main into main 2024-02-11 12:14:42 +00:00
Conversation 3 Commits 1 Files Changed 1 +1 -1
zotan commented 2024-02-09 09:31:03 +00:00
Contributor
Copy Link

This bug prevents federation with json-ld compliant ActivityPub implementations.

Same commit in:

This bug prevents federation with json-ld compliant ActivityPub implementations. Same commit in: - Iceshrimp: https://iceshrimp.dev/iceshrimp/iceshrimp/commit/4b20ab6ad4c23bb316222f723e3b1330f25d0315 - Firefish: https://firefish.dev/firefish/firefish/-/commit/da99f9c3aa5acc7fe816221b7d0ca448ee6bf494 - Misskey: https://github.com/misskey-dev/misskey/pull/11347
zotan added 1 commit 2024-02-09 09:31:04 +00:00
ci/woodpecker/pr/lint-client Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-sw Pipeline was successful Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful Details
ci/woodpecker/pr/test Pipeline was successful Details
c4849645de
activitypub: fix typo in audience.ts isPublic check
Johann150 manually merged commit c8f8e4c01d into main 2024-02-11 12:14:42 +00:00
Johann150 commented 2024-02-11 12:17:06 +00:00
Owner
Copy Link

for reference, the activitypub spec mentions this explicitly

5.6 public addressing

[...]
Compacting an ActivityStreams object using the ActivityStreams JSON-LD context might result in https://www.w3.org/ns/activitystreams#Public being represented as simply Public or as:Public which are valid representations of the Public collection. Implementations which treat ActivityStreams objects as simply JSON rather than converting an incoming activity over to a local context using JSON-LD tooling should be aware of this and should be prepared to accept all three representations.

for reference, the activitypub spec mentions this explicitly > ## [5.6 public addressing](https://www.w3.org/TR/activitypub/#public-addressing) >[...] >Compacting an ActivityStreams object using the ActivityStreams JSON-LD context might result in `https://www.w3.org/ns/activitystreams#Public` being represented as simply `Public` or `as:Public` which are valid representations of the Public collection. Implementations which treat ActivityStreams objects as simply JSON rather than converting an incoming activity over to a local context using JSON-LD tooling should be aware of this and should be prepared to accept all three representations.
Johann150 commented 2024-02-11 12:18:32 +00:00
Owner
Copy Link

Thanks for this fix, but does an LD compliant implementation even exist? lol

Thanks for this fix, but does an LD compliant implementation even exist? lol
zotan commented 2024-02-11 14:44:44 +00:00
Author
Contributor
Copy Link

The Iceshrimp rewrite & Takahe, and probably others :)

The [Iceshrimp rewrite](https://iceshrimp.dev/iceshrimp/iceshrimp.net) & [Takahe](https://github.com/jointakahe/takahe), and probably others :)
👀 1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#406
No description provided.
Delete Branch "zotan/FoundKey:main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?