fix: lint errors for textarea #48
Loading…
Reference in New Issue
No description provided.
Delete Branch "(deleted):fix/textarea"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
unsure of one thing
@ -99,3 +103,3 @@}invalid = inputEl.validity.badInput;invalid.value = inputEl.value?.validity.badInput || true;Not sure if this should default to true or false
Either way, using a logical or here is not the right solution. You probably meant to use
??instead.Since this ref will only be
nulluntil the element is loaded it should be better to default it tofalse.@ -73,1 +69,3 @@const inputEl = $ref(null);const focused = ref(false);const changed = ref(false);const invalid = ref(false);The contribution guide says to use ref sugar (i.e.
$ref), which means we can avoid writing.valueeverywhere. However I forgot that this means the variable may not beconstbecause it will be assigned to. The proper solution should be to useletinstead ofconst.Went ahead and fixed this stuff myself, since there were some things I wanted done a bit differently and didn't want to have you do all the details when I can just do it myself quicker. Hope that's okay for you.
Yeah, that's fine. Thanks for the feedback!
Pull request closed