FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

refactor: welcome.setup.vue to composition api #52

Merged
Johann150 merged 1 commits from :refactor/welcome.setup.vue into main 2022-08-02 09:16:45 +00:00
Conversation 0 Commits 1 Files Changed 1 +22 -35
norm commented 2022-08-01 20:58:10 +00:00
Owner
Copy Link
No description provided.
Johann150 reviewed 2022-08-02 08:20:05 +00:00
packages/client/src/pages/welcome.setup.vue Outdated
@ -50,1 +41,3 @@
this.submitting = true;
os.api('admin/accounts/create', {
username: username,
password: password,
Johann150 commented 2022-08-02 08:20:05 +00:00
Owner
Copy Link

Now that the this. is removed, this can be refactored like this:

{
	username,
	password,
}
Now that the `this.` is removed, this can be refactored like this: ```javascript { username, password, } ```
norm marked this conversation as resolved
norm force-pushed refactor/welcome.setup.vue from 30c0148614 to 0d99077720 2022-08-02 08:42:35 +00:00 Compare
Johann150 merged commit 30d8bc9259 into main 2022-08-02 09:16:45 +00:00
norm deleted branch refactor/welcome.setup.vue 2022-08-02 09:50:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#52
No description provided.
Delete Branch ":refactor/welcome.setup.vue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?