FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

fixed an error showing up when trying to renote a note in the 'home' visibility setting #56

Closed
emilis wants to merge 1 commits from emilis/FoundKey:fix/renoting-home-scope into main
pull from: emilis/FoundKey:fix/renoting-home-scope
merge into: FoundKeyGang:main
Conversation 1 Commits 1 Files Changed 1 +2 -2
emilis commented 2022-08-05 07:25:43 +00:00
First-time contributor
Copy Link

smol boy

smol boy
emilis added 1 commit 2022-08-05 07:25:43 +00:00
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
959c4258d3 fixed an error showing up when trying to renote a note in the 'home' visibility setting
Johann150 commented 2022-08-05 08:02:59 +00:00
Owner
Copy Link

Thanks for your contribution, however this should already be fixed in cbefddc071.

I'm also not sure if your solution would have been correct because renote can also contain a quote renote.

Thanks for your contribution, however this should already be fixed in cbefddc07148d59e643bc91f9ceb1d7fa3553255. I'm also not sure if your solution would have been correct because `renote` can also contain a quote renote.
Johann150 closed this pull request 2022-08-05 08:03:03 +00:00
Some checks failed
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#56
No description provided.
Delete Branch "emilis/FoundKey:fix/renoting-home-scope"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?