FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

Remove signToActivityPubGet option #83

Merged
Johann150 merged 2 commits from feat/signToActivityPubGet into main 2022-08-21 19:11:48 +00:00
Conversation 0 Commits 2 Files Changed 3 +2 -9
norm commented 2022-08-21 16:39:32 +00:00
Owner
Copy Link

Makes it so that all requests are signed, equivalent to
signToActivityPubGet always being true.

Splitting this from #31

Makes it so that all requests are signed, equivalent to signToActivityPubGet always being true. Splitting this from https://akkoma.dev/FoundKeyGang/FoundKey/pulls/31
norm added 1 commit 2022-08-21 16:39:33 +00:00
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/pr/build Pipeline failed Details
ci/woodpecker/push/lint-client Pipeline failed Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/push/test Pipeline failed Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
77bfc2450d Remove signToActivityPubGet option 
Makes it so that all requests are signed, equivalent to
signToActivityPubGet always being true.
norm added this to the (deleted) project 2022-08-21 16:40:16 +00:00
Johann150 requested changes 2022-08-21 17:05:00 +00:00
Johann150 left a comment
Owner
Copy Link

I think packages/backend/src/remote/activitypub/resolver.ts lines 79 and following could also be simplified because this.user will now always be set.

I think `packages/backend/src/remote/activitypub/resolver.ts` lines 79 and following could also be simplified because `this.user` will now always be set.
norm added 1 commit 2022-08-21 17:14:38 +00:00
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline failed Details
ci/woodpecker/push/test Pipeline failed Details
8e5a350f1b Simplify fetching object in resolver.ts 
this.user will always be true, so we aren't doing unsigned fetches.
Johann150 approved these changes 2022-08-21 19:11:39 +00:00
Johann150 merged commit 8e5a350f1b into main 2022-08-21 19:11:48 +00:00
Johann150 deleted branch feat/signToActivityPubGet 2022-08-21 19:11:48 +00:00
Johann150 added the
fix
 label 2022-12-23 10:20:59 +00:00
Johann150 removed this from the (deleted) project 2022-12-23 10:21:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#83
No description provided.
Delete Branch "feat/signToActivityPubGet"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?