FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

client: refactor user-preview to composition api #95

Closed
norm wants to merge 1 commits from refactor/user-preview into main
pull from: refactor/user-preview
merge into: FoundKeyGang:main
Conversation 1 Commits 1 Files Changed 1 +39 -55
norm commented 2022-08-29 20:30:39 +00:00
Owner
Copy Link
No description provided.
Johann150 requested changes 2022-08-29 20:49:42 +00:00
packages/client/src/components/user-preview.vue Outdated
@ -23,3 +23,3 @@
</div>
</div>
<MkFollowButton v-if="$i && user.id != $i.id" class="koudoku-button" :user="user" mini/>
<MkFollowButton v-if="user.id != $i?.id" class="koudoku-button" :user="user" mini/>
Johann150 commented 2022-08-29 20:48:51 +00:00
Owner
Copy Link

I think this change is not correct because we do not want to show a follow button to users that are not logged in. Hence we also explicitly check whether $i == null which would indicate not being logged in.

I think this change is not correct because we do not want to show a follow button to users that are not logged in. Hence we also explicitly check whether `$i == null` which would indicate not being logged in.
norm marked this conversation as resolved
norm force-pushed refactor/user-preview from 775a5ba668 to a6c1bdafe6 2022-08-29 20:52:47 +00:00 Compare
Johann150 closed this pull request 2022-08-30 17:09:45 +00:00
Johann150 commented 2022-08-30 17:10:17 +00:00
Owner
Copy Link

merged in 20f45e0179

merged in 20f45e0179f3144b5fbd9a4ff262bfc4613cf9a9
👍 1
Some checks failed
ci/woodpecker/push/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/push/lint-client Pipeline was successful
Details
ci/woodpecker/push/build Pipeline was successful
Details
ci/woodpecker/push/lint-backend Pipeline was successful
Details
ci/woodpecker/push/test Pipeline was successful
Details
ci/woodpecker/pr/lint-foundkey-js Pipeline was successful
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/build Pipeline was successful
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details
ci/woodpecker/pr/test Pipeline failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Johann150
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#95
No description provided.
Delete Branch "refactor/user-preview"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?