Move activities and movedTo field on actors
tl;dr about your specific question: signatures are verified in the handler for the inbox queue, specifically [starting from this line](https://akkoma.dev/FoundKeyGang/FoundKey/src/commit/f1d7357e…
Move activities and movedTo field on actors
Per discussion in preview review everything looks good to me, for whatever that's worth :)
Move activities and movedTo field on actors
Got it. Thanks for clarifying the data model, I see now what's happening there :) As I said, I'm still getting familiar with the code base.
Move activities and movedTo field on actors
Aha. Okay, I missed that bubbling up to a retry, thanks!
Move activities and movedTo field on actors
Do we expect this to be a common case? If no, it might be worth adding a warning log so that some data about how often this happens can be collected. The log can always be removed if it appears to be frequent. I bring this up since in my deployment of foundkey I've added some warning logs to a place to try and help me track down (which I'm not done doing so no PRs here) what I think are some bugs.
Move activities and movedTo field on actors
This would prevent cycles of a -> b -> a, right? It's uncommon but I've seen people do cycles like this in the past when, e.g. they move and then the instance they move to winds up blocking an instance they have a lot of connections with, or in the case of mastodon.lol their new instance shuts down.
Move activities and movedTo field on actors
The only reason I can think of to not auto accept is if the local user has follow requests turned on, right? But even then, if they already accepted the original request, then it feels silly to make them accept again. If it's technically difficult to do here for some reason, in which case it seems fine to leave this as a todo.
Move activities and movedTo field on actors
Overall this looks good. There's only one thing that stands out as a possible bug to me.
Move activities and movedTo field on actors
Something that might be worth refactoring in this PR but is otherwise fine: The CSS class text is used several times with a local override of opacity: 0.6 it might be worth factoring out a dedicated CSS class for this like dim-notification-text or even just a class that only applies the opacity. IIRC this will help a bit with rendering performance.
Move activities and movedTo field on actors
I understand having a warning in the log, but I'm not totally convinced that deleting the movedTo information makes sense to me?
Move activities and movedTo field on actors
Nobody has reviewed this pull request yet and I feel unable to review my own code.
I've been getting familiar with the code and would be open to doing a code review for you if that would help…
Move activities and movedTo field on actors
I'm curious what's blocking merging this with the big mastodon.lol shutdown foundkey not processing these is kinda screwing up my experience 😔
