fix: Notificationsの型を修正 #27

Merged

tamaina merged 9 commits from fix-notification into develop 2021-09-20 17:50:36 +00:00

Conversation 2 Commits 9 Files Changed 3 +12 -3

tamaina commented 2021-09-20 14:27:54 +00:00 (Migrated from github.com)

Copy Link

What

• groupInvitedにinvitationを追加
• appにheaderを追加

Why

型エラーが気になる

# What - groupInvitedにinvitationを追加 - appにheaderを追加 # Why 型エラーが気になる

codecov[bot] commented 2021-09-20 14:32:45 +00:00 (Migrated from github.com)

Copy Link

Codecov Report

Merging #27 (d223c36) into develop (1243e6a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #27   +/-   ##
========================================
  Coverage    94.70%   94.70%           
========================================
  Files            2        2           
  Lines          434      434           
  Branches        27       51   +24     
========================================
  Hits           411      411           
  Misses          23       23           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1243e6a...d223c36. Read the comment docs.

# [Codecov](https://codecov.io/gh/misskey-dev/misskey.js/pull/27?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#27](https://codecov.io/gh/misskey-dev/misskey.js/pull/27?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (d223c36) into [develop](https://codecov.io/gh/misskey-dev/misskey.js/commit/1243e6a655c47fc6f26b0fc6251d31a448a9995f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (1243e6a) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/misskey-dev/misskey.js/pull/27?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## develop #27 +/- ## ======================================== Coverage 94.70% 94.70% ======================================== Files 2 2 Lines 434 434 Branches 27 51 +24 ======================================== Hits 411 411 Misses 23 23 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/misskey-dev/misskey.js/pull/27?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/misskey-dev/misskey.js/pull/27?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [1243e6a...d223c36](https://codecov.io/gh/misskey-dev/misskey.js/pull/27?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).

syuilo commented 2021-09-20 17:50:38 +00:00 (Migrated from github.com)

Copy Link

👍

👍

This repo is archived. You cannot comment on pull requests.

Reviewers

No reviewers

Labels

Clear labels

No items

No Label

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

1 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: norm/foundkey.js#27

No description provided.