norm/foundkey.js
Archived
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity

Add missing main stream types #36

Merged
tamaina merged 5 commits from fix-streaming into develop 2021-12-29 05:54:10 +00:00
Conversation 4 Commits 5 Files changed 3 +2489 -2477
tamaina commented 2021-12-25 17:04:46 +00:00 (Migrated from github.com)
Copy link

Fix #35

What

本体の定義をもとにメインストリームの定義を追加します

Fix #35 # What [本体の定義](https://github.com/misskey-dev/misskey/blob/12.100.2/packages/backend/src/server/api/stream/types.ts#L45)をもとにメインストリームの定義を追加します
codecov[bot] commented 2021-12-25 17:05:47 +00:00 (Migrated from github.com)
Copy link

Codecov Report

Merging #36 (b6ba2be) into develop (d2b634c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #36   +/-   ##
========================================
  Coverage    95.20%   95.20%           
========================================
  Files            2        2           
  Lines          438      438           
  Branches        29       29           
========================================
  Hits           417      417           
  Misses          21       21

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2b634c...b6ba2be. Read the comment docs.

# [Codecov](https://codecov.io/gh/misskey-dev/misskey.js/pull/36?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) Report > Merging [#36](https://codecov.io/gh/misskey-dev/misskey.js/pull/36?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (b6ba2be) into [develop](https://codecov.io/gh/misskey-dev/misskey.js/commit/d2b634c3496d96dc2e1b476feae33ea69261d638?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) (d2b634c) will **not change** coverage. > The diff coverage is `n/a`. [![Impacted file tree graph](https://codecov.io/gh/misskey-dev/misskey.js/pull/36/graphs/tree.svg?width=650&height=150&src=pr&token=PbrTtk3nVD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://codecov.io/gh/misskey-dev/misskey.js/pull/36?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## develop #36 +/- ## ======================================== Coverage 95.20% 95.20% ======================================== Files 2 2 Lines 438 438 Branches 29 29 ======================================== Hits 417 417 Misses 21 21 ``` ------ [Continue to review full report at Codecov](https://codecov.io/gh/misskey-dev/misskey.js/pull/36?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/misskey-dev/misskey.js/pull/36?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [d2b634c...b6ba2be](https://codecov.io/gh/misskey-dev/misskey.js/pull/36?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
syuilo (Migrated from github.com) reviewed 2021-12-25 17:08:15 +00:00
src/streaming.types.ts
syuilo (Migrated from github.com) commented 2021-12-25 17:08:15 +00:00

文字列になってるのは意図的？

文字列になってるのは意図的？
tamaina (Migrated from github.com) reviewed 2021-12-25 17:09:26 +00:00
src/streaming.types.ts
tamaina (Migrated from github.com) commented 2021-12-25 17:09:26 +00:00

寝ぼけていた

寝ぼけていた
syuilo commented 2021-12-27 17:36:19 +00:00 (Migrated from github.com)
Copy link

API Reportがおかしいかも

API Reportがおかしいかも
tamaina commented 2021-12-28 06:35:10 +00:00 (Migrated from github.com)
Copy link

なおした

なおした
❤️ 1
syuilo commented 2021-12-29 05:54:16 +00:00 (Migrated from github.com)
Copy link

🙏

🙏
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: norm/foundkey.js#36
No description provided.
Delete branch "fix-streaming"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?