Auto-approve followbacks (frontend part) #365

Oneric · 2024-01-19T01:53:42Z

Oneric commented

2024-01-19 01:53:42 +00:00

Depends on the backend patches from AkkomaGang/akkoma#674 to actually take effect. See backend PR for further details.

Depends on the backend patches from https://akkoma.dev/AkkomaGang/akkoma/pulls/674 to actually take effect. See backend PR for further details.

Oneric referenced this pull request from AkkomaGang/akkoma

2024-01-19 01:54:13 +00:00

Add ability to auto-approve follow requests from followed users #674

katafrakt reviewed 2024-02-03 11:21:45 +00:00

src/i18n/en.json Outdated

					
				@ -600,6 +600,7 @@

				        "list_aliases_error": "Error fetching aliases: {error}",

				        "list_backups_error": "Error fetching backup list: {error}",

				        "lock_account_description": "Restrict your account to approved followers only",

				        "permit_followback_description": "Always approve follow requests from followed users",

katafrakt commented

2024-02-03 11:21:45 +00:00

First-time contributor

This is a nitpick, but I wonder if the message here is clear enough. Perhaps something like this would be more precise:

Automatically approve follow requests from users you already follow

?

This is a nitpick, but I wonder if the message here is clear enough. Perhaps something like this would be more precise: > Automatically approve follow requests from users you already follow ?

Oneric commented

2024-02-03 15:26:38 +00:00

Thanks for the suggestions, this is probably a bit easier to read, yeah

However, with “Automatically” the description gets longer than any other description currently on this page leading to linebreaks at widths which (at least in English) previously didn’t need any.
Just swapping “Automatically” for “Always” gets the text a bit below the current longest again though; for now I pushed this. Does this seem good or was “Automatically”-“Always” part of the confusing bit?

Alternatively the "follow request" part could be implied and “Automatically approve requests from already followed users” will also be short enough. Or maybe I’m just worrying too much about the linebreak and we should just use your original suggestion

Thanks for the suggestions, this is probably a bit easier to read, yeah However, with “Automatically” the description gets longer than any other description currently on this page leading to linebreaks at widths which (at least in English) previously didn’t need any. Just swapping “Automatically” for “Always” gets the text a bit below the current longest again though; for now I pushed this. Does this seem good or was “Automatically”-“Always” part of the confusing bit? Alternatively the "*follow* request" part could be implied and *“Automatically approve requests from already followed users”* will also be short enough. Or maybe I’m just worrying too much about the linebreak and we should just use your original suggestion

katafrakt commented

2024-02-04 20:35:16 +00:00

First-time contributor

I think it's actually "Automatic" vs "Always" that makes it a bit unclear. Not sure if the line length is that important here. "Automatically approve requests from already followed users" sounds good IMO.

Oneric commented

2024-02-04 21:20:04 +00:00

oki, changed it to the latter

(as for line length: on a typical desktop all of the discussed options are equally fine, but on tablets or phones using the mobile interface it might become relevant)

oki, changed it to the latter (as for line length: on a typical desktop all of the discussed options are equally fine, but on tablets or phones using the mobile interface it might become relevant)

Oneric marked this conversation as resolved

Oneric force-pushed followbacks-fe from 67bbf6971c to c065a46694

2024-02-03 15:14:48 +00:00

Compare

Oneric force-pushed followbacks-fe from c065a46694 to a77a9e04d9

2024-02-04 21:19:23 +00:00

Compare

floatingghost commented

2024-02-20 16:24:31 +00:00

:nodders: functionality all works

thankieos

:nodders: functionality all works thankieos