193 commits

Author	SHA1	Message	Date
Johann150	2d32bc33d7	server: fix error for invalid URLs in profile fields ... Co-authored-by: Chloe Kudryavtsev <code@code.bunkerlabs.net>	2023-01-30 19:24:15 +01:00
Chloe Kudryavtsev	bb3ec8bafe	Revert "server: fix user deletion race condition" ... This reverts commit cc83cbe523, reversing changes made to 8abd3ebec7. This changeset contains: * multiple type errors * a foreign key incompatibility * breaks outgoing note federation (in at least two ways)	2023-01-30 14:59:24 +01:00
Johann150	cc83cbe523	server: fix user deletion race condition ... Changelog: Fixed Ref: https://github.com/misskey-dev/misskey/issues/7506	2023-01-29 12:53:29 +01:00
Johann150	66ec875624	server: also search human readable URL ... Changelog: Fixed	2023-01-23 18:09:04 +01:00
Johann150	78f5ca3792	server: fix empty array in quote detection	2023-01-22 21:47:02 +01:00
Johann150	c792e4199c	server: add missing return in extractQuoteUrl	2023-01-22 21:42:49 +01:00
Johann150	5893a44ff5	server: parse quote tag syntax ... Ref: FEP-e232	2023-01-17 21:45:57 +01:00
Johann150	9bdf24d3a5	enhance: add tag for quotes ... Ref: FEP-e232	2023-01-17 21:45:49 +01:00
Johann150	80f72e21cd	server: track deletion completion	2023-01-08 21:22:03 +01:00
Johann150	85e985d13f	server: change data structure to track deletion completion	2023-01-08 21:21:54 +01:00
Johann150	cd26e3a35c	fixup: missing parenthesis	2023-01-08 19:34:03 +01:00
Johann150	1eda1760d1	server: refactor to always use deleteAccount service ... This should reduce code duplication around how deletion of an actor is handled.	2023-01-07 19:46:05 +01:00
Johann150	8772181b6f	server: refactor remote host check to validateActor ... Instead of checking that an actor is not from the local host separately, it seems like a good idea to do it in the central place that is supposed to validate an actor.	2023-01-07 19:46:05 +01:00
Johann150	48f8fb97df	activitypub: use quoteUri instead of quoteUrl ... It's not quite Mastodon, but still, I said they'd use a different approach... Changelog: Changed	2023-01-04 20:56:06 +01:00
Johann150	0230f819e2	fixup: wrong negation ... This is a fixup for commit 417d252e9d.	2023-01-04 19:09:03 +01:00
Johann150	0c8a3cfeec	server: fix lints	2023-01-03 03:51:38 +01:00
Johann150	417d252e9d	server: fix custom lint typeorm-prefer-count	2023-01-03 02:42:42 +01:00
Johann150	6010884e62	cleanup: translate japanese, use SECOND constant	2023-01-02 21:07:56 +01:00
Johann150	b423d23cf6	server: fix custom lint typeorm-prefer-count	2023-01-02 21:07:02 +01:00
Johann150	de3cdb5833	activitypub: block check for resolving collections	2022-12-24 18:39:44 -05:00
Francis Dinh	a732cdc1ad	activitypub: perform block check in performOneActivity	2022-12-24 18:39:44 -05:00
Francis Dinh	a8f82050c8	activitypub: perform resolver block check on objects as well	2022-12-24 18:39:44 -05:00
Francis Dinh	28f65bebfc	server: use named export for cancelFollowRequest	2022-12-22 16:52:52 -05:00
Francis Dinh	b11e4053db	server: use named export for acceptFollowRequest	2022-12-22 16:52:52 -05:00
Johann150	711bb8be7d	fixup: add missing redirect argument	2022-12-21 21:23:23 +01:00
Johann150	275136cf8b	allow redirects in API ap/* endpoints	2022-12-21 20:45:55 +01:00
Johann150	aa33708b90	server: handle redirects in signed get ... part of #288 Changelog: Fixed	2022-12-20 22:07:24 +01:00
Johann150	8c759dde6c	server: fix error about duplicate resolve	2022-12-15 19:44:55 +01:00
Johann150	16d091497a	server: use extractDbHost instead of toPuny, translate comments ... Also swapped logical or for nullish coalescing operator in some places.	2022-12-15 00:32:15 +01:00
Johann150	ef53ec276a	activitypub: simplify some URI/id related checks ... followup on previous commit	2022-12-15 00:31:23 +01:00
Johann150	3582fd8260	activitypub: centrally check id matches URL in resolver ... This makes some duplicated checks in models/note and models/person unnecessary.	2022-12-15 00:29:39 +01:00
Johann150	ccc8bf0289	chore: fix more miscellaneous lints	2022-12-13 23:09:32 +01:00
Johann150	8e9c65fab0	chore: fix some import related lints	2022-12-13 23:09:31 +01:00
Francis Dinh	a9d3cae511	server: add return type to extractApMentions	2022-12-13 16:31:15 -05:00
Francis Dinh	bd27b7ca3a	server: add typing for renderFollowRelay	2022-12-13 16:06:18 -05:00
Johann150	768d9bbdfb	refactor: remove default export for perform	2022-12-11 18:23:19 +01:00
Johann150	3ef1a4b0f9	refactor: remove default export for Resolver	2022-12-11 18:23:07 +01:00
Johann150	ae59ce51b0	refactor: remove default export for DbResolver	2022-12-11 18:16:48 +01:00
Johann150	14a9b9bedd	refactor: remove default export for request	2022-12-11 18:16:45 +01:00
Johann150	985a13f47f	refactor: remove default export for DeliverManager	2022-12-11 17:56:25 +01:00
Johann150	507b328fdf	activitypub: also forward resolver to resolveNote	2022-12-10 11:23:10 +01:00
Johann150	1faf1035f9	server: handle users getting deleted somewhere else ... I don't know why but several jobs got stuck in my inbox queue because of errors like 'Could not find any entity of type "User" matching...'.	2022-12-08 18:12:24 +01:00
Johann150	e2ce599aca	fix: properly supply resolver	2022-12-08 18:12:05 +01:00
Francis Dinh	b66f7550ab	server: auto-fix lints	2022-12-07 13:39:21 -05:00
Andreas Nedbal	1aa3898db5	server: remove unused import	2022-12-06 23:12:45 +01:00
Andreas Nedbal	4cc5b734e7	activitypub: remove integration fields from person and nodeinfo	2022-12-06 21:49:19 +01:00
Norm	c1a51547a9	BREAKING: server: remove wildcard blocking and instead block subdomains (#269) ... Co-authored-by: Francis Dinh <normandy@biribiri.dev> Reviewed-on: #269 Changelog: Changed	2022-12-05 17:55:38 +00:00
Johann150	a421dd401c	activitypub: refactor to always apply recursion limit ... Refactor to remove as many "new Resolver" as possible.	2022-12-04 21:11:44 +01:00
Johann150	03b673165f	server: refactor "authUser" functions into separate file ... They did not really fit into the DbResolver because they may fetch data from remote instances even though DbResolver is only supposed to access the database.	2022-12-04 21:11:35 +01:00
Johann150	194fff3603	activitypub: hashtags no longer displaying as links ... Some hashtags sent from Mastodon were erroneously displayed as links. This is because Mastodon seems to mangle hashtags containing non-ASCII codepoints (such as e.g. umlauts). This lead to the previous code which depended on the list of hashtags to not recognize a hashtag. Instead, the `rel="tag"` microformat is recognized instead. This makes the `htmlToMfm` wrapper function unnecessary so it was removed. Changelog: Fixed	2022-12-02 19:31:57 +01:00
Johann150	b4080d788d	slight refactoring & translating japanese	2022-12-02 19:00:58 +01:00
Johann150	e49b8d0ef3	server: remove unnecessary apLogger aliases	2022-12-02 18:58:19 +01:00
Johann150	9ad37a12f8	server: fix rendering of Follow activity when removing follow ... closes #263 Changelog: Fixed	2022-12-01 21:49:38 +01:00
Norm	e10700a2be	Merge pull request 'server: add wildcard matching to blocked hosts' (#260) from wildcard-block-v2 into main ... Reviewed-on: #260	2022-12-01 20:12:18 +00:00
Johann150	721a327192	fixup: remove unused import	2022-12-01 20:46:46 +01:00
Johann150	936cbf900b	use default argument value ... This unifies the style with the other function in that file and fixes the lint "no-param-reassign".	2022-12-01 20:32:57 +01:00
Francis Dinh	075e251822	server: add wildcard matching to blocked hosts ... This adds in wildcard matching. For instance: - `*.bad.tld` will match: `very.bad.tld` - `bad.*` will match: `bad.something` - `*.bad.*` will match: `very.bad.evil` Changelog: Changed	2022-12-01 11:29:02 -05:00
Derek Schmidt	11a6e706f4	server: Use shared resolver in featured and question accept	2022-12-01 04:40:14 -05:00
Derek Schmidt	d3af00a912	server: Add recursion limit to resolver ... Changelog: Security	2022-12-01 04:40:07 -05:00
Johann150	7ee6a09cf2	fix errors from quote string removal ... The parse5 tree does not have the full DOM methods and attributes.	2022-11-21 19:43:56 +01:00
Johann150	9e2553909e	server: use time constants	2022-11-20 23:15:40 +01:00
Johann150	66a7c62342	activitypub: remove akkoma quote URLs ... Changelog: Fixed	2022-11-20 20:48:15 +00:00
Johann150	d1ec058d5c	server: refactor Cache to hold fetcher as attribute ... Instead of having to pass the fetcher every time you want to fetch something, the fetcher is stored in an attribute of the Cache.	2022-11-13 19:39:30 +01:00
Johann150	8979e779da	server: optimise follower inboxes query ... Use the distinct query thingy so we don't have to make the Set work so hard. This is also uniform code with the "everyone" above so should hopefully be easier to understand.	2022-11-12 15:09:50 +01:00
Michcio	d725f93d40	backend: Provide type for signedGet	2022-10-31 10:10:29 +01:00
Johann150	2aafe8fc9f	server: avoid adding suspended instances to deliver queue ... This should reduce the performance hit when adding large numbers of instances to the deliver queue by making the check for suspended and dead instances a bulk operation. Changelog: Changed Reviewed-on: #215	2022-10-29 22:58:04 +02:00
Francis Dinh	d83c1c3851	backend: use named exports for services/note	2022-10-20 21:16:34 -04:00
Johann150	0b8fa2665c	use DISTINCT instead of GROUP BY ... This should have better performance for large recordsets. Ref: #198 (comment)	2022-10-11 20:15:59 +02:00
Johann150	8920eeb86a	ActivityPub: allow all known shared inboxes to be addressed ... This is oriented on this paragraph from the AP spec: > Additionally, if an object is addressed to the Public special collection, > a server MAY deliver that object to all known sharedInbox endpoints > on the network.	2022-10-11 00:27:43 +02:00
Johann150	36a0e48e49	bacakend: prefer absolute over relative imports ... There are still many places where import paths with `..` are used and maybe should use absolute paths also.	2022-10-01 14:40:30 +02:00
Francis Dinh	57f4312a27	chore: Change Misskey references to Foundkey ... Also remove the contributors list from about-foundkey (renamed from about-misskey). Some comments that referenced Misskey were also translated to English. Closes: #141	2022-09-13 13:19:36 -04:00
Johann150	7a981de883	refactor: remove note.mentionedRemoteUsers column ... The column mentionedRemoteUsers on the note table in the database is firstly in the wrong type since it contains JSON data but is typed as text. Secondly it seems redundant, since that data can be acquired by using the note.mentions column to fetch the respective data instead. Co-authored-by: Francis Dinh <normandy@biribiri.dev>	2022-09-07 14:43:04 +02:00
Johann150	3bdbbcadd9	adjust MFM to HTML conversion ... Removed the misc/get-note-html module which was only used in one place. Instead of it, the general MFM to HTML functionality has been improved to take care of the use cases of that module as well. Co-authored-by: Francis Dinh <normandy@biribiri.dev>	2022-09-07 14:42:39 +02:00
Johann150	375323bc25	update parameter type and docs	2022-09-02 14:28:55 +02:00
Francis Dinh	8e5a350f1b	Simplify fetching object in resolver.ts ... this.user will always be true, so we aren't doing unsigned fetches.	2022-08-21 13:13:34 -04:00
Francis Dinh	77bfc2450d	Remove signToActivityPubGet option ... Makes it so that all requests are signed, equivalent to signToActivityPubGet always being true.	2022-08-21 12:38:43 -04:00
Johann150	c8afce6b2c	fix blocking of remote accounts ... The property name was misspelled.	2022-08-14 11:33:08 +02:00
Johann150	6ce4b3fe2f	fix some lints ... Many of these were fixed automatically with eslint --fix. Some of them (e.g. adding return types to functions) were done manually.	2022-08-11 00:09:29 +02:00
Johann150	7a80015225	fix lint "no-param-reassign"	2022-08-10 16:36:54 +02:00
Johann150	09a7eabda1	backend: fix lint "no-throw-literal"	2022-08-04 11:00:02 +02:00
Johann150	c8f49bae76	fix lint "object-shorthand"	2022-08-03 14:58:24 +02:00
Johann150	37e47a257e	fix lints "import/order" and "import/no-duplicate" ... Also simplified some import paths by replacing relative with absolute paths.	2022-08-03 14:05:50 +02:00
Johann150	a6df127d3b	fix lint "quotes"	2022-08-02 23:25:36 +02:00
Johann150	6060e7d220	enhance: better rendering of reports ... Passing the report object reduces the number of parameters to be passed.	2022-07-19 17:18:19 +02:00
Johann150	d92d389cda	extract note URLs from Activity	2022-07-19 17:18:18 +02:00
Johann150	912c19222e	fix lints	2022-07-13 10:42:16 +02:00
yzhe819	9111d238c1	chore: fix lint errors (#8981)	2022-07-13 00:45:57 +02:00
Johann150	ba0236700d	chore: remove unused imports	2022-07-12 14:41:10 +02:00
Johann150	9a1e6bf10f	fix: render empty note content correctly ... Instead of coercing to `null`, coercing to an empty string should simplify handling.	2022-07-09 05:38:38 -04:00
Johann150	bc9c79b9ef	fix: correctly render note text ... Fix a regression from #8787 that was previously fixed in #8440.	2022-07-09 05:35:27 -04:00
Johann150	a683a7092d	enhance(federation): use ActivityPub defined property in favour of proprietary property. (#8787) ... * add activitypub `source` property * parse MFM from new `source` attribute	2022-06-10 14:31:58 +09:00
syuilo	11afdf7e24	fix bug	2022-06-04 15:15:44 +09:00
Johann150	32dff28460	fix: add id for activitypub follows (#8689) ... * add id for activitypub follows * fix lint * fix: follower must be local, followee must be remote Misskey will only use ActivityPub follow requests for users that are local and are requesting to follow a remote user. This check is to ensure that this endpoint can not be used by other services or instances. * fix: missing import * render block with id * fix comment	2022-06-04 13:52:42 +09:00
Johann150	9954c054a7	fix: ensure resolver does not fetch local resources via HTTP(S) (#8733) ... * refactor: parseUri types and checks The type has been refined to better represent what it actually is. Uses of parseUri are now also checking the parsed object type before resolving. * cannot resolve URLs with fragments * also take remaining part of URL into account Needed for parsing the follows URIs. * Resolver uses DbResolver for local * remove unnecessary use of DbResolver Using DbResolver would mean that the URL is parsed and handled again. This duplicated processing can be avoided by querying the database directly. * fix missing property name	2022-06-04 11:29:20 +09:00
Johann150	81109b14b5	fix: correctly render empty note text (#8746) ... Ensure that the _misskey_content attribute will always exist. Because the API endpoint does not require the existence of the `text` field, that field may be `undefined`. By using `?? null` it can be ensured that the value is at least `null`. Furthermore, the rendered HTML of a note with empty text will also be the empty string. From git blame it seems that this behaviour was added because of a Mastodon bug that might have previously existed. Hoever, this seems to be no longer the case as I can find mastodon posts that have empty content. The code could be made a bit more succinct by using the null coercion operator.	2022-06-03 23:18:44 +09:00
Johann150	804fa33535	refactor: improve code quality (#8751) ... * remove unnecessary if `Array.prototype.some` already returns a boolean so an if to return true or false is completely unnecessary in this case. * perf: use count instead of find When using `count` instead of `findOneBy`, the data is not unnecessarily loaded. * remove duplicate null check The variable is checked for null in the lines above and the function returns if so. Therefore, it can not be null at this point. * simplify `getJsonSchema` Because the assigned value is `null` and the used keys are only shallow, use of `nestedProperty.set` seems inappropriate. Because the value is not read, the initial for loop can be replaced by a `for..in` loop. Since all keys will be assigned `null`, the condition of the ternary expression in the nested function will always be true. Therefore the recursion case will never happen. With this the nested function can be eliminated. * remove duplicate condition The code above already checks `dragging` and returns if it is truthy. Checking it again later is therefore unnecessary. To make this more obvious the `return` is removed in favour of using an if...else construct. * remove impossible "unknown" time The `ago` variable will always be a number and all non-negative numbers are already covered by other cases, the negative case is handled with `future` so there is no case when `unkown` could be achieved.	2022-05-29 15:15:52 +09:00
Johann150	e54aa56ee1	chore: remove unused imports	2022-05-28 21:17:23 +02:00
Johann150	6b109c7b0f	fix: wrong type for isVisibleForMe	2022-05-24 10:12:42 +02:00
Johann150	edfded7fb7	fix(activitypub): add authorization checks (#8534) ... * fix spelling * fix(activitypub): add authorization checks	2022-05-19 20:40:16 +09:00
syuilo	ce51ef5df5	refactor	2022-04-17 21:01:02 +09:00