FoundKeyGang/FoundKey
FoundKeyGang/FoundKey
7
19
Fork 22
Code Issues 37 Pull requests 4 Releases Activity

server: avoid adding suspended instances to deliver queue #215

Manually merged
Johann150 merged 1 commit from refactor/deliver-manager into main 2022-10-29 20:59:27 +00:00
Conversation 0 Commits 1 Files changed 3 +68 -21
Johann150 commented 2022-10-28 23:47:56 +00:00
Owner
Copy link

This should reduce the performance hit when adding large numbers of instances to the deliver queue by making the check for suspended and dead instances a bulk operation.

Changelog: Changed

This should reduce the performance hit when adding large numbers of instances to the deliver queue by making the check for suspended and dead instances a bulk operation. Changelog: Changed
Johann150 force-pushed refactor/deliver-manager from e1dea45911 to f0c21caef3 2022-10-28 23:58:35 +00:00 Compare
Johann150 force-pushed refactor/deliver-manager from f0c21caef3 to 7ac30ecfbf 2022-10-29 01:13:58 +00:00 Compare
norm reviewed 2022-10-29 05:10:28 +00:00
packages/backend/src/misc/skipped-instances.ts
@ -0,0 +31,4 @@
// also avoids adding duplicates to the list
hosts: hosts.filter(host => !skipped.includes(host)),
})
.andWhere(new Brackets(qb => { qb
norm commented 2022-10-29 05:10:28 +00:00
Owner
Copy link

Nitpick: the second qb probably could be on the next line

Nitpick: the second qb probably could be on the next line
Johann150 commented 2022-10-29 09:48:22 +00:00
Author
Owner
Copy link

Just copied that style from elsewhere in the codebase so the following lines line up.

Just copied that style from elsewhere in the codebase so the following lines line up.
norm marked this conversation as resolved
Johann150 manually merged commit 2aafe8fc9f into main 2022-10-29 20:59:27 +00:00
Johann150 deleted branch refactor/deliver-manager 2022-10-29 20:59:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No labels
feature
fix
upkeep
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#215
No description provided.
Delete branch "refactor/deliver-manager"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?