FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

remove ads #5

Manually merged
Johann150 merged 4 commits from remove-ads into main 2022-07-13 21:27:40 +00:00
Conversation 4 Commits 4 Files Changed 38 +17 -678
Johann150 commented 2022-07-11 20:34:26 +00:00
Owner
Copy Link

Remove client components, API endpoints, type definitions and database tables pertaining to Ads.

Fixes #3.

Remove client components, API endpoints, type definitions and database tables pertaining to Ads. Fixes #3.
toast commented 2022-07-12 00:55:53 +00:00
Owner
Copy Link

Other things related to ads I found:

  • packages/backend/src/server/api/endpoints/admin/meta.ts (ads:)
  • various locale files (ads:)
  • packages/client/src/store.ts (mutedAds:)

Decided not to remove them myself rn because I'm rather drunk and don't want to commit something broken ^^;;

Other things related to ads I found: * packages/backend/src/server/api/endpoints/admin/meta.ts (`ads:`) * various locale files (`ads:`) * packages/client/src/store.ts (`mutedAds:`) Decided not to remove them myself rn because I'm rather drunk and don't want to commit something broken ^^;;
👍 1
Johann150 added 15 commits 2022-07-13 11:05:47 +00:00
Johann150 force-pushed remove-ads from bcb4efec5b to 3f010357de 2022-07-13 11:07:54 +00:00 Compare
toast commented 2022-07-13 18:14:09 +00:00
Owner
Copy Link

I think a few of these commits were supposed to go into main, not into the remove ads pr ^^;;

I think a few of these commits were supposed to go into main, not into the remove ads pr ^^;;
Johann150 commented 2022-07-13 20:12:46 +00:00
Author
Owner
Copy Link

Several of the commits shown here are not even part of the PR. The commits tab says there are 4 commits. 🥴

Several of the commits shown here are not even part of the PR. The commits tab says there are 4 commits. 🥴
toast commented 2022-07-13 20:59:10 +00:00
Owner
Copy Link

GITEAAAAAA

GITEAAAAAA
Johann150 force-pushed remove-ads from 3f010357de to 29284eca75 2022-07-13 21:22:53 +00:00 Compare
Johann150 manually merged commit 29284eca75 into main 2022-07-13 21:27:40 +00:00
Johann150 deleted branch remove-ads 2022-07-13 21:28:05 +00:00
norm referenced this issue from a commit 2022-08-28 14:46:46 +00:00
Rename render acct (#5)
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#5
No description provided.
Delete Branch "remove-ads"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?