client: consolidate pages #104
Loading…
Reference in a new issue
No description provided.
Delete branch "feat/mentions-page"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Pulled from
0f1c0a42a2The following pages are consolidated:
Changelog: Changed
0ae5f37bcetof0ba8d1877WIP: client: reorganize notifications pageto client: reorganize notifications pageclient: reorganize notifications pageto client: consolidate pageschanged the title since the change also affected the about page as well
client: consolidate pagesto client: reorganize menusclient: reorganize menusto client: consolidate pages@ -4,3 +4,2 @@<MkSpacer :content-max="800"><div class="clupoqwt"><XNotifications class="notifications" :include-types="includeTypes" :unread-only="tab === 'unread'"/><div v-if="tab === 'all' || tab === 'unread'">I think if you use this as the default/
v-elsecase, you wouldn't have to use this condition and also catch the case where someone enters a URL fragment by hand which does not match any of the defined tabs.But on the other hand, since other code also depends on it, it might be a good idea to just check that
initialTabis a valid tab anyway.I changed that to a
v-elsecase and also added a ternary for thetabref to make it default toallif it's not a valid tab id.@ -39,3 +66,3 @@}const headerActions = $computed(() => [{const headerActions = $computed(() => [tab === 'all' ? {Since both of these array elements depend on
tab === 'all', you might as well write@ -191,3 +191,3 @@case 'users': return defineAsyncComponent(() => import('./users.vue'));case 'emojis': return defineAsyncComponent(() => import('./emojis.vue'));case 'federation': return defineAsyncComponent(() => import('../federation.vue'));//case 'federation': return defineAsyncComponent(() => import('../federation.vue'));I don't think we need to keep this dead code around.