server: always enable push notifications #235

Johann150 · 2022-11-16T19:58:22Z

Johann150 commented

2022-11-16 19:58:22 +00:00

The thing that previously presumably hindered this was that the VAPID keys had to be set up. Previously admins had to do this, but this is a bad idea for multiple reasons:

The meaning of "public key" and "private key" was not well documented in the settings.
Giving out a private key over the API, even just for admins, sounds like a bad idea.

The thing that previously presumably hindered this was that the VAPID keys had to be set up. Previously admins had to do this, but this is a bad idea for multiple reasons: 1) The meaning of "public key" and "private key" was not well documented in the settings. 2) Giving out a private key over the API, even just for admins, sounds like a bad idea.

norm commented

2022-11-21 19:24:34 +00:00

It looks like that migration might not be working properly: https://toot.site/@jeder/109382304525913598

Johann150 force-pushed enable-push-notifs from 7a82a3d262 to 36c3e1ccc5

2022-11-21 19:58:20 +00:00

Compare

norm requested changes 2022-11-21 20:31:26 +00:00

packages/backend/migration/1668374092227-forceEnablePush.js Outdated

					
				@ -0,0 +7,4 @@

						// generate VAPID keys if not yet set

						const keysSet = await queryRunner.query(`SELECT "swPublicKey" IS NOT NULL AND "swPrivateKey" IS NOT NULL as set FROM "meta"`);

						// if there is no meta entry yet, the keys will be generated on initial setup

						if (keysSet.length > 0 && !keysSet.set) {

norm commented

2022-11-21 20:31:24 +00:00

This check should be keysSet.length === 0 and the query should be

SELECT "swPublicKey", "swPrivateKey" FROM "meta" where "swPublicKey" IS NOT NULL AND "swPrivateKey" IS NOT NULL

Otherwise this doesn't get run and will result in a non-null constraint error.

This check should be `keysSet.length === 0` and the query should be ```sql SELECT "swPublicKey", "swPrivateKey" FROM "meta" where "swPublicKey" IS NOT NULL AND "swPrivateKey" IS NOT NULL ``` Otherwise this doesn't get run and will result in a non-null constraint error.

norm commented

2022-11-21 20:36:51 +00:00

Could also be possible to just do

await queryRunner.query(`UPDATE "meta" SET "swPublicKey" = $1, "swPrivateKey" = $2 WHERE "swPublicKey" IS NULL OR "swPrivateKey" IS NULL`, [publicKey, privateKey]);

Could also be possible to just do ```js await queryRunner.query(`UPDATE "meta" SET "swPublicKey" = $1, "swPrivateKey" = $2 WHERE "swPublicKey" IS NULL OR "swPrivateKey" IS NULL`, [publicKey, privateKey]); ```

norm marked this conversation as resolved

Johann150 force-pushed enable-push-notifs from 36c3e1ccc5 to 563f3672a9

2022-11-21 21:01:18 +00:00

Compare

Johann150 added 1 commit 2022-11-21 21:30:46 +00:00