FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

refactor: post-form-attaches to composition api #57

Closed
norm wants to merge 18 commits from (deleted):refactor/post-form-attaches into main
pull from: (deleted):refactor/post-form-attaches
merge into: FoundKeyGang:main
Conversation 1 Commits 18 Files Changed 282 +2291 -1949
norm commented 2022-08-05 19:34:35 +00:00
Owner
Copy Link
No description provided.
norm added 1 commit 2022-08-05 19:34:36 +00:00
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
e2fbd2468e
refactor: post-form-attaches to composition api
Johann150 reviewed 2022-08-10 22:31:44 +00:00
packages/client/src/components/post-form-attaches.vue Outdated
@ -17,2 +17,2 @@
<script lang="ts">
import { defineComponent, defineAsyncComponent } from 'vue';
<script lang="ts" setup>
import { defineProps, defineAsyncComponent, defineEmits, computed } from 'vue';
Johann150 commented 2022-08-10 22:26:55 +00:00
Owner
Copy Link

defineProps and defineEmits are compiler macros only usable inside <script setup>. They do not need to be imported, and are compiled away when <script setup> is processed.

-- https://vuejs.org/api/sfc-script-setup.html#defineprops-defineemits

> `defineProps` and `defineEmits` are compiler macros only usable inside `<script setup>`. They do not need to be imported, and are compiled away when `<script setup>` is processed. -- https://vuejs.org/api/sfc-script-setup.html#defineprops-defineemits
norm marked this conversation as resolved
packages/client/src/components/post-form-attaches.vue
@ -134,0 +118,4 @@
text: i18n.ts.attachCancel,
icon: 'fas fa-times-circle',
action: (): void => { detachMedia(file.id); },
}], ev.currentTarget ?? ev.target).then(() => menu = null);
Johann150 commented 2022-08-10 22:31:24 +00:00
Owner
Copy Link

A bit inconsistent that here there is no return type annotated but above void is explicitly annotated. IMHO annotating void there makes little sense.

A bit inconsistent that here there is no return type annotated but above `void` is explicitly annotated. IMHO annotating `void` there makes little sense.
norm marked this conversation as resolved
norm added 1 commit 2022-08-11 00:19:40 +00:00
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
db34aadcb6 Remove unneeded imports/return annotations
norm added 16 commits 2022-08-11 00:23:11 +00:00
f49736d2b0 Update 'CHANGELOG.md' 
Add in changes that were made since FoundKey diverged from upstream
a2ccd2e71a Archive old changelog 
This reverts commit 62d1f0acbd and moves
the current changelog to CHANGELOG-OLD.md.

The current format is pretty messy and wasn't really much better than a
git shortlog. Changelogs are meant for end-users to know what changed
between versions. Most probably won't care much about refactors but may
be interested in UI changes, feature additions/removals, and maybe
client API changes (for 3rd party clients).
96fefa2a52 Create new changelog 
This changelog uses the Keep a Changelog format: https://keepachangelog.com/en/1.0.0/
8c21083437 refactor group pages to composition API 
This solves some errors from just reinstating the pages since the new
routing and tab implementation have a different API.
753e252ff6 fix: use correct variable 
Fixes an error introduced in commit 7a80015225.
c7a87eff8c fix some lints 
Many of these were fixed automatically with eslint --fix.

Some of them (e.g. adding return types to functions) were done manually.
53947c4506 remove unnecessary vue imports 
> `defineProps` and `defineEmits` are compiler macros only usable inside
> `<script setup>`. They do not need to be imported, and are compiled away
> when `<script setup>` is processed.

-- https://vuejs.org/api/sfc-script-setup.html#defineprops-defineemits
ci/woodpecker/pr/build Pipeline failed Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/test Pipeline failed Details
ci/woodpecker/pr/lint-client Pipeline failed Details
727323c37a remove unused code
norm commented 2022-08-11 00:26:50 +00:00
Author
Owner
Copy Link

Superceeded by #60

Superceeded by https://akkoma.dev/FoundKeyGang/FoundKey/pulls/60
norm closed this pull request 2022-08-11 00:26:51 +00:00
norm deleted branch refactor/post-form-attaches 2022-08-11 00:26:55 +00:00
Some checks failed
ci/woodpecker/pr/build Pipeline failed
Details
ci/woodpecker/pr/lint-backend Pipeline was successful
Details
ci/woodpecker/pr/test Pipeline failed
Details
ci/woodpecker/pr/lint-client Pipeline failed
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#57
No description provided.
Delete Branch "(deleted):refactor/post-form-attaches"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?