FoundKeyGang/FoundKey
FoundKeyGang
/
FoundKey
7
19
Fork 22
Code Issues 37 Pull Requests 4 Releases Activity

refactor: post-form-attaches to composition api #60

Merged
Johann150 merged 5 commits from :refactor/post-form-attaches.vue into main 2022-08-11 09:17:17 +00:00
Conversation 0 Commits 5 Files Changed 1 +99 -111
norm commented 2022-08-11 00:26:37 +00:00
Owner
Copy Link

Redoing this PR since there was some rebasing mishap with the other one

Redoing this PR since there was some rebasing mishap with the other one
norm added 2 commits 2022-08-11 00:26:38 +00:00
ci/woodpecker/pr/build Pipeline failed Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/test Pipeline failed Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ed52a39476 Remove unneeded imports/return annotations
norm added 1 commit 2022-08-11 00:50:04 +00:00
ci/woodpecker/pr/build Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
091bf0f77b fix syntax error
norm added 1 commit 2022-08-11 00:57:22 +00:00
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
21b78274aa more syntax fixes
Johann150 reviewed 2022-08-11 06:12:20 +00:00
packages/client/src/os.ts Outdated
@ -239,6 +239,7 @@ export function inputText(props: {
text?: string | null;
placeholder?: string | null;
default?: string | null;
allowEmpty?: boolean;
Johann150 commented 2022-08-11 06:07:15 +00:00
Owner
Copy Link

This value is not used here...

This value is not used here...
norm marked this conversation as resolved
norm added 1 commit 2022-08-11 08:07:34 +00:00
ci/woodpecker/pr/lint-backend Pipeline was successful Details
ci/woodpecker/pr/build Pipeline was successful Details
ci/woodpecker/pr/lint-client Pipeline failed Details
ci/woodpecker/pr/test Pipeline failed Details
ci/woodpecker/push/lint-backend Pipeline was successful Details
ci/woodpecker/push/build Pipeline was successful Details
ci/woodpecker/push/lint-client Pipeline failed Details
ci/woodpecker/push/test Pipeline failed Details
534666f762 remove allowEmpty
Johann150 merged commit 534666f762 into main 2022-08-11 09:17:17 +00:00
norm deleted branch refactor/post-form-attaches.vue 2022-08-11 10:24:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
feature

task that proposes new feature(s)

  
fix

task to fix behavioral problems in the FoundKey codebase

  
upkeep

task that should make FoundKey smaller and more maintainable

No Label
feature
fix
upkeep
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: FoundKeyGang/FoundKey#60
No description provided.
Delete Branch ":refactor/post-form-attaches.vue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?