I run macOS but I'm not sure what your issue is. Could you give more details on how replicate or what the issue is?
If you are doing local development, disabling SSL verification or installing…
extractHost
, extractHostname
, punyHost
, or something similar? I'm not sure; I mostly think the Db
in the name doesn't make much more sense when used in such contexts, even if that's where…
As this is uses fixups, rebase merge is preferable to not pollute Git history
I want to make sure the code and check condition are clear on the signature verification step, which is common practice on sensitive code. Additionally, while the typings do specify that the…
I based myself on the inbox
code which uses the same code. I will apply the patch to my submission, but the inbox
code should probably be patched to match. (PS: I find extractDbHost
to be…
I would've liked to replace the inbox
signature code with this function, but JSON-LD and the reliance on the actor
field of an activity (as well as relay logic) would make it difficult without…
The export
is a mistake, yes. I thought that it would be easier to implement a feature to allow users to block specific instances from accessing their activities, if it was done this way, but…
Update
activities for Notes
I'd assume it's also used for Delete
s; it does not seem to be used in the alternative path for updateNote
though, which could be a problem (I assume that is why there was a unlock()
there…
Update
activities for Notes
I assume this is used to get exclusive ownership of an AP object?
Update
activities for Notes
Much cleaner than whatever hacked-up copypastes I could've came up with; I can't attest to it working or not (I don't run an instance and can't tell from the code itself as I'm not familiar enough with the codebase) but I don't have much to say here other than it looks good to me and the refactoring (splitting side-effects etc in a different file for Notes) is pretty important and helps a lot for the cleanliness and clarity of this feature.
deliver
to extract actor from activity
Could it be possible that user
might be wrong or null?
deliver
to extract actor from activity
Sounds like a TS typing would be preferable here, considering this field is required?