Hélène helene
  • Joined on 2022-08-19
helene commented on issue AkkomaGang/akkoma#585 2023-07-14 09:45:03 +00:00
[feat] Provide way to override root certs used for federation

I run macOS but I'm not sure what your issue is. Could you give more details on how replicate or what the issue is?

If you are doing local development, disabling SSL verification or installing…

helene commented on pull request FoundKeyGang/FoundKey#399 2023-06-25 19:56:24 +00:00
BREAKING: activitypub: validate fetch signatures

extractHost, extractHostname, punyHost, or something similar? I'm not sure; I mostly think the Db in the name doesn't make much more sense when used in such contexts, even if that's where…

helene commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 17:58:03 +00:00
BREAKING: activitypub: validate fetch signatures

As this is uses fixups, rebase merge is preferable to not pollute Git history

helene pushed to feature/verify-fetch-signatures at helene/FoundKey 2023-06-23 17:54:00 +00:00
fe0dde38c3 fixup! BREAKING: activitypub: validate fetch signatures
helene commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 17:13:13 +00:00
BREAKING: activitypub: validate fetch signatures

I want to make sure the code and check condition are clear on the signature verification step, which is common practice on sensitive code. Additionally, while the typings do specify that the…

helene commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 17:02:40 +00:00
BREAKING: activitypub: validate fetch signatures

I based myself on the inbox code which uses the same code. I will apply the patch to my submission, but the inbox code should probably be patched to match. (PS: I find extractDbHost to be…

helene commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 16:59:37 +00:00
BREAKING: activitypub: validate fetch signatures

I would've liked to replace the inbox signature code with this function, but JSON-LD and the reliance on the actor field of an activity (as well as relay logic) would make it difficult without…

helene commented on pull request FoundKeyGang/FoundKey#399 2023-06-23 16:57:30 +00:00
BREAKING: activitypub: validate fetch signatures

The export is a mistake, yes. I thought that it would be easier to implement a feature to allow users to block specific instances from accessing their activities, if it was done this way, but…

helene created pull request FoundKeyGang/FoundKey#399 2023-06-23 14:30:48 +00:00
BREAKING: activitypub: validate fetch signatures
helene pushed to feature/verify-fetch-signatures at helene/FoundKey 2023-06-23 14:30:16 +00:00
f89a374e5f BREAKING: activitypub: validate fetch signatures
f7904a240a client: fix MFM overflow
693dd3ad97 remove unused parameter from MFM component
Compare 3 commits »
helene created branch feature/verify-fetch-signatures in helene/FoundKey 2023-06-23 14:29:23 +00:00
helene pushed to feature/verify-fetch-signatures at helene/FoundKey 2023-06-23 14:29:23 +00:00
cf75dfe319 BREAKING: activitypub: validate fetch signatures
777b981bf1 client: disable sound for received note by default
bbd35054e6 change my name in mailmap
e9862d480c Translated using Weblate (Japanese)
cc0915775b server: add webhook stat to nodeinfo
Compare 10 commits »
helene commented on pull request FoundKeyGang/FoundKey#395 2023-06-11 16:13:39 +00:00
handle Update activities for Notes

I'd assume it's also used for Deletes; it does not seem to be used in the alternative path for updateNote though, which could be a problem (I assume that is why there was a unlock() there…

helene commented on pull request FoundKeyGang/FoundKey#395 2023-06-09 19:35:05 +00:00
handle Update activities for Notes

s/unkown/unknown

helene commented on pull request FoundKeyGang/FoundKey#395 2023-06-09 19:35:05 +00:00
handle Update activities for Notes

I assume this is used to get exclusive ownership of an AP object?

helene commented on pull request FoundKeyGang/FoundKey#395 2023-06-09 19:35:05 +00:00
handle Update activities for Notes

unlock is undefined here, I suggest removing the finally block

helene commented on pull request FoundKeyGang/FoundKey#395 2023-06-09 19:35:05 +00:00
handle Update activities for Notes

s/udpatedAt/updatedAt

helene suggested changes for FoundKeyGang/FoundKey#395 2023-06-09 19:35:05 +00:00
handle Update activities for Notes

Much cleaner than whatever hacked-up copypastes I could've came up with; I can't attest to it working or not (I don't run an instance and can't tell from the code itself as I'm not familiar enough with the codebase) but I don't have much to say here other than it looks good to me and the refactoring (splitting side-effects etc in a different file for Notes) is pretty important and helps a lot for the cleanliness and clarity of this feature.

helene commented on pull request FoundKeyGang/FoundKey#377 2023-04-19 20:53:59 +00:00
refactor deliver to extract actor from activity

Could it be possible that user might be wrong or null?

helene commented on pull request FoundKeyGang/FoundKey#377 2023-04-19 20:53:59 +00:00
refactor deliver to extract actor from activity

Sounds like a TS typing would be preferable here, considering this field is required?