9438 commits

Author	SHA1	Message	Date
Floatingghost	1ffbaa2924	don't allow a nil inbox to obliterate federation	2025-01-06 11:43:41 +00:00
floatingghost	39cef8b8d2	Merge pull request 'Set customize_hostname_check for Swoosh.Adapters.SMTP' (#861) from norm/akkoma:smtp-defaults-fix into develop ... Reviewed-on: #861	2025-01-05 15:43:16 +00:00
floatingghost	3ba743d635	Merge pull request 'Update hashtag prune to account for followed hashtags' (#844) from norm/akkoma:hashtag-prune into develop ... Reviewed-on: #844	2025-01-05 15:41:23 +00:00
floatingghost	8de373fa24	Merge pull request 'Fix various attachment cleanup issues' (#789) from Oneric/akkoma:attachcleanup-overeager into develop ... Reviewed-on: #789	2025-01-05 15:39:48 +00:00
floatingghost	7c095a6b70	Merge pull request 'do not fetch if :limit_to_local_content is :all or :unauthenticated' (#582) from beerriot/akkoma:develop-no-fetch-with-local-limit into develop ... Reviewed-on: #582	2025-01-05 15:39:13 +00:00
Oneric	e8bf4422ff	Delay attachment deletion ... Otherwise attachments have a high chance to disappear with akkoma-fe’s “delete & redraft” feature when cleanup is enabled in the backend. Since we don't know whether a deletion was intended to be part of a redraft process or even if whether the redraft was abandoned we still have to delete attachments eventually. A thirty minute delay should provide sufficient time for redrafting. Fixes: #775	2025-01-03 20:49:11 +01:00
Oneric	bcfbfbcff5	Don't try to cleanup remote attachments ... The cleanup attachment worker was run for every deleted post, even if it’s a remote post whose attachments we don't even store. This was especially bad due to attachment cleanup involving a particularly heavy query wasting a bunch of database perf for nil. This was uncovered by comparing statistics from #784 and #765 (comment)	2025-01-03 20:48:46 +01:00
floatingghost	e3c8c4f24f	Merge pull request 'mrf/object_age: fix handling of non-public objects' (#851) from Oneric/akkoma:mrf-fix-oage into develop ... Reviewed-on: #851	2025-01-03 15:26:11 +00:00
floatingghost	67cdc38296	Merge pull request 'Only proxy HTTP and HTTP urls via Media Proxy' (#860) from nopjmp/akkoma:media-proxy-only-http into develop ... Reviewed-on: #860	2025-01-03 15:25:14 +00:00
floatingghost	89d209f486	Merge pull request 'Fix NodeInfo content-type' (#853) from Oneric/akkoma:nodeinfo-contenttype into develop ... Reviewed-on: #853	2025-01-03 15:24:25 +00:00
floatingghost	91bedcfa68	Merge pull request 'Completely omit id for anonymous objects' (#850) from Oneric/akkoma:ap-anonymous-errata into develop ... Reviewed-on: #850	2025-01-03 15:23:03 +00:00
Norm	f19d5d1380	Set customize_hostname_check for Swoosh.Adapters.SMTP ... This should hopefully fix issues with connecting to SMTP servers with wildcard TLS certificates. Taken from https://erlef.github.io/security-wg/secure_coding_and_deployment_hardening/ssl Fixes #660	2024-12-18 14:37:27 -05:00
nopjmp	7632765b43	Only proxy HTTP and HTTP urls via Media Proxy ... We make an assumption that we are only proxying HTTP/HTTPS hosted media through the media proxy endpoint. Fixes: #859	2024-12-16 20:35:12 -06:00
Oneric	294de939cb	signing_key: refactor nested case into with statement ... The error branches were already effectively identical before. This change is purely cosmetic.	2024-12-08 20:43:57 +00:00
Haelwenn (lanodan) Monnier	2b1a252cc7	User: truncate remote user fields instead of rejecting	2024-11-26 09:29:44 +00:00
Oneric	416aebb76a	Fix NodeInfo content-type ... Fixes: #852	2024-11-19 19:25:31 +01:00
Oneric	932810c35e	mrf/object_age: fix handling of non-public objects ... Current logic unconditionally adds public adressing to "cc" and follower adressing to "to" after attempting to strip it from the other one. This creates serious problems: First the bug prompting this investigation and fix, unconditional addition creates duplicates when adressing URIs already were in their intended final field; e.g. this is prominently the case for all "unlisted" posts. Since List.delete only removes the first occurence, this then broke follower-adress stripping later on making the policy ineffective. It’s also just not safe in general wrt to non-public adressing: e.g. pre-existing duplicates didn’t get fully stripped, bespoke adressing modes with only one of public addressing or follower addressing are mangled — and most importantly: any belatedly received DM or follower-only post also got public adressing added! Shockingly this last point was actually asserted as "correct" in tests; it appears to be a mistake from mindless match adjustments while fixing crashes on nil adressing in 10c792110e. Clean up this sloppy logic up, making sure no more duplicates are added by us, all instances of relevant adresses are purged and only readded when they actually existed to begin with.	2024-11-17 00:44:51 +01:00
Oneric	0f9c9aac38	Completely omit id for anonymous objects ... Current AP spec demands anonymous objects to have an id value, but explicitly set it to JSON null. Howeveras it turns out this is incompatible with JSON-LD requiring `@id` to be a string and thus AP spec is incompatible iwth the Ativity Streams spec it is based on. This is an issue for (the few) AP implementers actually performing JSON-LD processing, like IceShrimp.NET. This was uncovered by IceShrimp.NET’s zotan due to our adoption of anonymous objects for emoj in f101886709. The issues is being discussed by W3C, and will most likely be resolved via an errata redefining anonymous objects to completely omit the id field just like transient objects already do. See: https://github.com/w3c/activitypub/issues/476 Fixes: #848	2024-11-09 19:29:29 +01:00
Floatingghost	c0a99df06a	Merge remote-tracking branch 'oneric/varfixes' into develop	2024-10-30 15:15:00 +00:00
Floatingghost	11c5838947	standardise local key id generation	2024-10-30 12:44:01 +00:00
Floatingghost	d330c57cda	make sure we correctly match key objects	2024-10-26 08:42:07 +01:00
Floatingghost	9d2c558f64	remove unused import	2024-10-26 07:42:43 +01:00
Floatingghost	ac25b051ae	remove previous "allow user routes" functionality	2024-10-26 07:28:43 +01:00
Floatingghost	58d5d9d7bf	fix tests, contain object	2024-10-26 06:58:47 +01:00
Floatingghost	b6e8fde4dd	Merge branch 'develop' into keys-extraction	2024-10-26 06:11:29 +01:00
Floatingghost	bee10eab5e	correct minor zip behaviour	2024-10-26 06:11:12 +01:00
Floatingghost	13215f5f06	remove public key field	2024-10-26 05:28:55 +01:00
Floatingghost	430b376ded	mix format	2024-10-26 05:05:48 +01:00
Floatingghost	ccf1007883	Fix about a million tests	2024-10-26 05:05:48 +01:00
Floatingghost	6da783b84d	Fix http signature plug tests	2024-10-26 05:05:48 +01:00
Floatingghost	8f322456a0	Allow unsigned fetches of a user's public key	2024-10-26 05:05:48 +01:00
Floatingghost	9c876cea21	Fix some tests	2024-10-26 05:05:48 +01:00
Floatingghost	9728e2f8f7	adjust logic to use relation :signing_key	2024-10-26 05:05:47 +01:00
Floatingghost	b0f7da9ce0	remove now-unused Keys module	2024-10-26 05:05:28 +01:00
Floatingghost	fc99c694e6	Add signing key modules	2024-10-26 05:05:28 +01:00
Floatingghost	fbb13fde76	Merge branch 'develop' of akkoma.dev:AkkomaGang/akkoma into develop	2024-10-26 05:04:27 +01:00
Floatingghost	cbd236aeb5	mix format	2024-10-26 05:04:20 +01:00
floatingghost	71d3bbd7be	Merge pull request 'Fix wrong type when importing emojis' (#841) from tudbut/akkomafixes:emojis into develop ... Reviewed-on: #841	2024-10-26 04:00:12 +00:00
Norm	88a8086ad3	Use LEFT JOIN instead of UNION for hashtag pruning	2024-10-25 12:26:14 -04:00
Norm	40da4e88ea	Update hashtag prune to account for followed hashtags ... Currently pruning hashtags with the prune_objects task only accounts for whether that hashtag is associated with an object, but this may lead to a foreign key constraint violation if that hashtag has no objects but is followed by a local user. This adds an additional check to see if that hashtag has any followers before proceeding to delete it.	2024-10-25 11:55:37 -04:00
TudbuT	661b7fedb6	fix wrong type when importing emojis	2024-10-18 14:57:31 +02:00
TudbuT	8b5aca9619	fix fs error while unpacking frontends	2024-10-18 14:50:28 +02:00
floatingghost	f101886709	Merge pull request 'Federate emoji as anonymous objects' (#815) from Oneric/akkoma:emoji-id into develop ... Reviewed-on: #815	2024-10-16 14:58:46 +00:00
Oneric	d5b0720596	Allow cross-domain redirects on AP requests ... Since we now remember the final location redirects lead to and use it for all further checks since 3e134b07fa, these redirects can no longer be exploited to serve counterfeit objects. This fixes: - display URLs from independent webapp clients redirecting to the canonical domain - Peertube display URLs for remote content (acting like the above)	2024-10-14 01:42:51 +02:00
Oneric	940792f8ba	Refetch on AP ID mismatch ... As hinted at in the commit message when strict checking was added in 8684964c5d, refetching is more robust than display URL comparison but in exchange is harder to implement correctly. A similar refetch approach is also employed by e.g. Mastodon, IceShrimp and FireFish. To make sure no checks can be bypassed by forcing a refetch, id checking is placed at the very end. This will fix: - Peertube display URL arrays our transmogrifier fails to normalise - non-canonical display URLs from alternative frontends (theoretical; we didnt’t get any actual reports about this) It will also be helpful in the planned key handling overhaul. The modified user collision test was introduced in https://git.pleroma.social/pleroma/pleroma/-/merge_requests/461 and unfortunately the issues this fixes aren’t public. Afaict it was just meant to guard against someone serving faked data belonging to an unrelated domain. Since we now refetch and the id actually is mocked, lookup now succeeds but will use the real data from the authorative server making it unproblematic. Instead modify the fake data further and make sure we don’t end up using the spoofed version.	2024-10-14 01:42:43 +02:00
floatingghost	3bb31117e6	Merge pull request 'Handle domain mutes on the backend' (#804) from domain-mute-backend-processing into develop ... Reviewed-on: #804	2024-08-20 10:32:47 +00:00
Floatingghost	2c5c531c35	readd comment about domain mutes	2024-08-20 11:05:36 +01:00
Oneric	a3101a435b	Fix swagger-ui ... Ever since the browser frontend switcher was introduced in de64c6c54a /akkoma counts as an API prefix and thus gets skipped by frontend plugs breaking the old swagger ui path of /akkoma/swagger-ui. Do the simple thing and change the frontend path to /pleroma/swaggerui which isn't an API path and can't collide with frontend user paths given pleroma is areserved nickname. Reported in https://meta.akkoma.dev/t/view-all-endpoints/269/7 https://meta.akkoma.dev/t/swagger-ui-not-loading/728	2024-06-27 18:29:45 +02:00
Oneric	d488cf476e	Fix voters count field ... Mastodon API demands this be null unless it’s a multi-selection poll. Not abiding by this can mess up display in some clients. Fixes: #190	2024-06-27 18:29:45 +02:00
Oneric	ca182a0ae7	Correctly parse content types with multiple profiles ... Multiple profiles can be specified as a space-separated list and the possibility of additional profiles is explicitly brought up in ActivityStream spec	2024-06-27 18:29:45 +02:00