qbism/qb_akkoma
1
0
Fork 0
forked from AkkomaGang/akkoma
Code Issues Pull requests Projects Releases Packages Wiki Activity

stable #3

Merged
qbism merged 128 commits from AkkomaGang/akkoma:stable into stable 2023-05-28 01:21:52 +00:00
Conversation 0 Commits 128 Files changed 109 +3749 -2505
qbism commented 2023-05-28 01:19:58 +00:00
Owner
Copy link
No description provided.
qbism added 128 commits 2023-05-28 01:19:58 +00:00 
Docs used to be a separate repo who cloned pleroma and pelroma-fe.
Now the docs are just the BE docs and completely part of the Akkoma repo.
I moved back to using venv because that's what I used and cleaner imo since it keeps everything nice in the repo.
(Iirc virtualenv stored things in the Home folder or smthng)
seems like this hasn't been run in a while. putting this in a separate
commit so the changes i'm about to make don't get drowned in all of this
stuff.
Markdown doesn't generally consider `\n` a newline,
but Misskey does for MFM.

Now we do to for MFM (and not for Markdown) :)
Reviewed-on: AkkomaGang/akkoma#478
Reviewed-on: AkkomaGang/akkoma#475
Reviewed-on: AkkomaGang/akkoma#484
By default Postgresql first restores the data and then the indexes when dumping and restoring the database.
Restoring index activities_visibility_index took a very long time.
users_ap_id_COALESCE_follower_address_index was later added because having this could speed up the restoration tremendously.
The problem now is that restoration apparently happens in alphabetical order, so this new index wasn't created yet
by the time activities_visibility_index needed it.
There were several work-arounds which included more complex steps during backup/restore.
By renaming this index, it should be restored first and thus activities_visibility_index can make use of it.
This speeds up restoration significantly without requiring more complex or unexpected steps from people.
We renamed another index is the previous commit so that this work-around isn't needed any more
We add an option to also prune remote activities who don't have existing objects any more they reference.
Rn, we only check for activities who only reference one object, not an array or embeded object.
E.g. Flag activities have an array of objects

We prune the activity when NONE of the objects can be found

Note that the cost of finding and deleting these is ~4x higher than finding and deleting the non-array ones

Only string:
Delete on activities  (cost=506573.48..506580.38 rows=0 width=0)

Only Array:
Delete on activities  (cost=3570359.68..4276365.34 rows=0 width=0)

(They are still executed separately, so the total cost is the sum of the two)
I also added extra info on VACUUM FULL
Reviewed-on: AkkomaGang/akkoma#448
Reviewed-on: AkkomaGang/akkoma#455
Reviewed-on: AkkomaGang/akkoma#474
Reviewed-on: AkkomaGang/akkoma#473
Fixes #450
Reviewed-on: AkkomaGang/akkoma#489
Reviewed-on: AkkomaGang/akkoma#486
Reviewed-on: AkkomaGang/akkoma#472
Fixes #463
Fixes #492
Expose quote posting in the api as a feature.

Copies what the quote post PR for pleroma does to allow external clients to enable and disable features based on the feature-set of the instance.

As far as I am aware, akkoma doesn't allow you to disable quote posting, so this doesn't need anything fancy and it's just a hard on switch.

I tried to get one for the bubble tl to work also, but I'm not quite sure how to do it so that it switches off the feature when the bubble tl is disabled. I would argue that it could and ideally should be done as well though.

I also discovered a pretty tame bug in the testing of it, that deleting the DB entry for the bubble tl does not stop the bubble TL from actually working and it will continue to display the panel on the about page, I'll just leave it as a note here.

Reviewed-on: AkkomaGang/akkoma#496
Co-authored-by: foxing <foxing@noreply.akkoma>
Co-committed-by: foxing <foxing@noreply.akkoma>
Reviewed-on: AkkomaGang/akkoma#498
Co-authored-by: FloatingGhost <hannah@coffee-and-dreams.uk>
Reviewed-on: AkkomaGang/akkoma#500
When no image description is filled in, Pleroma allowed fallbacks.
Those were (based on a setting) either the filename, or a fixed description.
Neither are good options for image descriptions imo, so here we remove this.

Note that there's two tests removed who supposedly tested something else.
But examining closer, they didn't seem to test what they claimed to test,
so I removed them rather than try to "fix" them.
weird values in href will cause base64 encoding to fail later down the
line, so let's make sure the value we're passing on is somewhat sane, or
at the very least a binary

this fixes #482
Reviewed-on: AkkomaGang/akkoma#506
Reviewed-on: AkkomaGang/akkoma#507
Reviewed-on: AkkomaGang/akkoma#502
TODO: PLEASE FOR THE LOVE OF KANATAN CACHE THIS
This reverts commit 1d94f2a424.
Reviewed-on: AkkomaGang/akkoma#517
Reviewed-on: AkkomaGang/akkoma#518
Reviewed-on: AkkomaGang/akkoma#512
Reviewed-on: AkkomaGang/akkoma#493
Fixes #528
This make the behavior consistent between when UserNote doesn't exist and when comment is null.

The current behavior may return null in APIs, which misleads some clients doing feature detection into thinking the server does not support comments.
For example, see https://codeberg.org/husky/husky/issues/92
Several tests for prune_objetcs need a date older than the deadline for pruning, so I moved that to the setup
When doing prune_objects, it's possible that bookmarked objects are deleted.
This gave problems when fetching the bookmark TL.
Here we clean up the bookmarks during pruning in the case were it's possible that bookmarked objects are deleted.
Reviewed-on: AkkomaGang/akkoma#544
Reviewed-on: AkkomaGang/akkoma#535
Reviewed-on: AkkomaGang/akkoma#530
Reviewed-on: AkkomaGang/akkoma#542
qbism merged commit 56f3479d4d into stable 2023-05-28 01:21:52 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: qbism/qb_akkoma#3
No description provided.
Delete branch "AkkomaGang/akkoma:stable"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?